From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55032) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtaT5-0005U1-F4 for qemu-devel@nongnu.org; Thu, 19 Dec 2013 05:04:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtaSx-0000ej-IK for qemu-devel@nongnu.org; Thu, 19 Dec 2013 05:04:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtaSx-0000eW-AE for qemu-devel@nongnu.org; Thu, 19 Dec 2013 05:04:27 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJA4Qnt025654 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Dec 2013 05:04:26 -0500 Message-ID: <52B2C4CA.5060806@redhat.com> Date: Thu, 19 Dec 2013 12:04:58 +0200 From: Orit Wasserman MIME-Version: 1.0 References: <1387293974-24718-1-git-send-email-quintela@redhat.com> <1387293974-24718-34-git-send-email-quintela@redhat.com> In-Reply-To: <1387293974-24718-34-git-send-email-quintela@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 33/38] kvm: refactor start address calculation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela , qemu-devel@nongnu.org On 12/17/2013 05:26 PM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > kvm-all.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/kvm-all.c b/kvm-all.c > index 308dfba..cb62ba4 100644 > --- a/kvm-all.c > +++ b/kvm-all.c > @@ -382,7 +382,8 @@ static int kvm_get_dirty_pages_log_range(MemoryRegionSection *section, > { > unsigned int i, j; > unsigned long page_number, c; > - hwaddr addr, addr1; > + hwaddr addr; > + ram_addr_t start = section->offset_within_region + section->mr->ram_addr; > ram_addr_t ram_addr; > unsigned int pages = int128_get64(section->size) / getpagesize(); > unsigned int len = (pages + HOST_LONG_BITS - 1) / HOST_LONG_BITS; > @@ -399,9 +400,8 @@ static int kvm_get_dirty_pages_log_range(MemoryRegionSection *section, > j = ffsl(c) - 1; > c &= ~(1ul << j); > page_number = (i * HOST_LONG_BITS + j) * hpratio; > - addr1 = page_number * TARGET_PAGE_SIZE; > - addr = section->offset_within_region + addr1; > - ram_addr = section->mr->ram_addr + addr; > + addr = page_number * TARGET_PAGE_SIZE; > + ram_addr = start + addr; > cpu_physical_memory_set_dirty_range(ram_addr, > TARGET_PAGE_SIZE * hpratio); > } while (c != 0); > Reviewed-by: Orit Wasserman