From: Eduardo Otubo <otubo@linux.vnet.ibm.com>
To: Corey Bryant <coreyb@linux.vnet.ibm.com>
Cc: pmoore@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails
Date: Thu, 19 Dec 2013 09:35:06 -0200 [thread overview]
Message-ID: <52B2D9EA.7070004@linux.vnet.ibm.com> (raw)
In-Reply-To: <1387385291-7825-1-git-send-email-coreyb@linux.vnet.ibm.com>
On 12/18/2013 02:48 PM, Corey Bryant wrote:
> This fixes a bug where we weren't exiting if seccomp_init() failed.
>
> Signed-off-by: Corey Bryant <coreyb@linux.vnet.ibm.com>
> ---
> qemu-seccomp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/qemu-seccomp.c b/qemu-seccomp.c
> index cf07869..b7c1253 100644
> --- a/qemu-seccomp.c
> +++ b/qemu-seccomp.c
> @@ -231,6 +231,7 @@ int seccomp_start(void)
>
> ctx = seccomp_init(SCMP_ACT_KILL);
> if (ctx == NULL) {
> + rc = -1;
> goto seccomp_return;
> }
>
ACK.
Reviewed-by: Eduardo Otubo <otubo@linux.vnet.ibm.com>
--
Eduardo Otubo
IBM Linux Technology Center
next prev parent reply other threads:[~2013-12-19 11:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-18 16:48 [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails Corey Bryant
2013-12-19 11:35 ` Eduardo Otubo [this message]
2013-12-19 15:59 ` Paul Moore
2013-12-19 20:41 ` Michael Roth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B2D9EA.7070004@linux.vnet.ibm.com \
--to=otubo@linux.vnet.ibm.com \
--cc=aliguori@amazon.com \
--cc=coreyb@linux.vnet.ibm.com \
--cc=pmoore@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).