From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48617) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtbsy-0002vG-GH for qemu-devel@nongnu.org; Thu, 19 Dec 2013 06:35:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vtbsp-0006ZH-Ie for qemu-devel@nongnu.org; Thu, 19 Dec 2013 06:35:24 -0500 Received: from e24smtp04.br.ibm.com ([32.104.18.25]:58573) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtbsp-0006Yt-6B for qemu-devel@nongnu.org; Thu, 19 Dec 2013 06:35:15 -0500 Received: from /spool/local by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 19 Dec 2013 09:35:09 -0200 Received: from d24relay01.br.ibm.com (d24relay01.br.ibm.com [9.8.31.16]) by d24dlp01.br.ibm.com (Postfix) with ESMTP id 51DB83520054 for ; Thu, 19 Dec 2013 06:35:06 -0500 (EST) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay01.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rBJBZChs4702214 for ; Thu, 19 Dec 2013 09:35:12 -0200 Received: from d24av05.br.ibm.com (localhost [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rBJBZ6P2001116 for ; Thu, 19 Dec 2013 06:35:06 -0500 Message-ID: <52B2D9EA.7070004@linux.vnet.ibm.com> Date: Thu, 19 Dec 2013 09:35:06 -0200 From: Eduardo Otubo MIME-Version: 1.0 References: <1387385291-7825-1-git-send-email-coreyb@linux.vnet.ibm.com> In-Reply-To: <1387385291-7825-1-git-send-email-coreyb@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Corey Bryant Cc: pmoore@redhat.com, qemu-devel@nongnu.org, aliguori@amazon.com On 12/18/2013 02:48 PM, Corey Bryant wrote: > This fixes a bug where we weren't exiting if seccomp_init() failed. > > Signed-off-by: Corey Bryant > --- > qemu-seccomp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/qemu-seccomp.c b/qemu-seccomp.c > index cf07869..b7c1253 100644 > --- a/qemu-seccomp.c > +++ b/qemu-seccomp.c > @@ -231,6 +231,7 @@ int seccomp_start(void) > > ctx = seccomp_init(SCMP_ACT_KILL); > if (ctx == NULL) { > + rc = -1; > goto seccomp_return; > } > ACK. Reviewed-by: Eduardo Otubo -- Eduardo Otubo IBM Linux Technology Center