From: Eric Blake <eblake@redhat.com>
To: armbru@redhat.com, qemu-devel@nongnu.org
Cc: afaerber@suse.de, aliguori@amazon.com, lcapitulino@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant
Date: Thu, 19 Dec 2013 08:48:28 -0700 [thread overview]
Message-ID: <52B3154C.2070809@redhat.com> (raw)
In-Reply-To: <1387463413-20070-1-git-send-email-armbru@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 667 bytes --]
On 12/19/2013 07:30 AM, armbru@redhat.com wrote:
> From: Markus Armbruster <armbru@redhat.com>
>
>
> We've since abandoned our quest for "rich" error objects, fortunately
> before it turned all error messages into mush. Time to undo the
> damage to this one. Make it:
>
> qemu: -device nonexistant: nonexistant is not a valid device model name
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> qdev-monitor.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-12-19 15:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 14:30 [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant armbru
2013-12-19 15:48 ` Eric Blake [this message]
2013-12-20 11:13 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B3154C.2070809@redhat.com \
--to=eblake@redhat.com \
--cc=afaerber@suse.de \
--cc=aliguori@amazon.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).