From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55669) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtfq1-0001CR-6b for qemu-devel@nongnu.org; Thu, 19 Dec 2013 10:48:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vtfpw-0003og-A6 for qemu-devel@nongnu.org; Thu, 19 Dec 2013 10:48:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtfpw-0003oa-0h for qemu-devel@nongnu.org; Thu, 19 Dec 2013 10:48:32 -0500 Message-ID: <52B3154C.2070809@redhat.com> Date: Thu, 19 Dec 2013 08:48:28 -0700 From: Eric Blake MIME-Version: 1.0 References: <1387463413-20070-1-git-send-email-armbru@redhat.com> In-Reply-To: <1387463413-20070-1-git-send-email-armbru@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="UvgWbHHpafV54XTqWKVDRWStMR8NXNlSv" Subject: Re: [Qemu-devel] [PATCH] qdev-monitor: Improve error message for -device nonexistant List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: armbru@redhat.com, qemu-devel@nongnu.org Cc: afaerber@suse.de, aliguori@amazon.com, lcapitulino@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --UvgWbHHpafV54XTqWKVDRWStMR8NXNlSv Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/19/2013 07:30 AM, armbru@redhat.com wrote: > From: Markus Armbruster >=20 >=20 > We've since abandoned our quest for "rich" error objects, fortunately > before it turned all error messages into mush. Time to undo the > damage to this one. Make it: >=20 > qemu: -device nonexistant: nonexistant is not a valid device model = name >=20 > Signed-off-by: Markus Armbruster > --- > qdev-monitor.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --UvgWbHHpafV54XTqWKVDRWStMR8NXNlSv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSsxVMAAoJEKeha0olJ0NqWbQH/AsJGuhcdWNQn4XnpRs8mZVk BbXQiA5U4nlLsPK+dgHngRiQEgPmGd0ZRkGkJdTjj9/EVIDDR1n5K3X5ik1A93Ex /guW3VJCsXrs5x3/6h5/0j/0QReifGjqx+n6hmq+yquP6iY6WatxPCILxeglyQ4i jcU37bZFWF8doAuI/vONRF8byIKmopMkMYX+t+9bYuOKZoM7qWTUrT9uhkFpHzBO aq+fAnmiBbfM+0xUfSdFoO6L1aHnB3axImtD3940SXZw6IkpSDI8u+OU5nWiBFxD OZiBRyghADrRxjhV9dcSmciVPgZa7ZQxpcyb6+iSeiEPwXLYnG+JZzTFhg9fxMQ= =RgdP -----END PGP SIGNATURE----- --UvgWbHHpafV54XTqWKVDRWStMR8NXNlSv--