From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, "Michael Matz" <matz@suse.de>,
"Claudio Fontana" <claudio.fontana@linaro.org>,
"Dirk Mueller" <dmueller@suse.de>,
"Will Newton" <will.newton@linaro.org>,
"Laurent Desnogues" <laurent.desnogues@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
kvmarm@lists.cs.columbia.edu,
"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns
Date: Thu, 19 Dec 2013 11:29:11 -0800 [thread overview]
Message-ID: <52B34907.1040109@twiddle.net> (raw)
In-Reply-To: <1387293144-11554-8-git-send-email-peter.maydell@linaro.org>
On 12/17/2013 07:12 AM, Peter Maydell wrote:
> + tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2);
> + if (is_sub) {
> + tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp);
> + } else {
> + tcg_gen_add_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp);
> + }
Perhaps worth noticing the RA=XZR special case for the MUL alias?
Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2013-12-19 19:29 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 15:12 [Qemu-devel] [PATCH 00/21] target-arm: A64 decoder sets 3 and 4: everything but fp & simd Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 01/21] target-arm: A64: add support for ld/st pair Peter Maydell
2013-12-19 16:58 ` Richard Henderson
2013-12-19 17:25 ` Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 02/21] target-arm: A64: add support for ld/st unsigned imm Peter Maydell
2013-12-19 17:46 ` Richard Henderson
2013-12-20 16:08 ` Peter Maydell
2013-12-20 16:26 ` Richard Henderson
2013-12-20 16:29 ` Peter Maydell
2013-12-20 16:44 ` Richard Henderson
2013-12-20 16:52 ` Peter Maydell
2013-12-20 16:57 ` Richard Henderson
2013-12-20 17:16 ` Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 03/21] target-arm: A64: add support for ld/st with reg offset Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 04/21] target-arm: A64: add support for ld/st with index Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 05/21] target-arm: A64: add support for add, addi, sub, subi Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 06/21] target-arm: A64: add support for move wide instructions Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3 src data proc insns Peter Maydell
2013-12-19 19:29 ` Richard Henderson [this message]
2013-12-20 13:18 ` Peter Maydell
2013-12-20 14:10 ` Richard Henderson
2013-12-20 14:19 ` Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 08/21] target-arm: A64: implement SVC, BRK Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 09/21] target-arm: A64: Add decoder skeleton for FP instructions Peter Maydell
2013-12-19 20:00 ` Richard Henderson
2013-12-17 15:12 ` [Qemu-devel] [PATCH 10/21] target-arm: A64: implement FMOV Peter Maydell
2013-12-19 20:18 ` Richard Henderson
2013-12-17 15:12 ` [Qemu-devel] [PATCH 11/21] target-arm: Update generic cpreg code for AArch64 Peter Maydell
2013-12-19 6:01 ` Peter Crosthwaite
2013-12-19 9:11 ` Peter Maydell
2013-12-20 4:24 ` Peter Crosthwaite
2013-12-20 10:00 ` Peter Maydell
2013-12-20 18:16 ` Peter Maydell
2013-12-20 21:41 ` Peter Crosthwaite
2013-12-20 22:07 ` Peter Maydell
2013-12-20 22:16 ` Peter Maydell
2013-12-22 19:50 ` Peter Maydell
2013-12-20 22:29 ` Peter Crosthwaite
2013-12-20 23:04 ` Peter Maydell
2013-12-20 17:41 ` Peter Maydell
2013-12-20 4:25 ` Peter Crosthwaite
2013-12-20 16:43 ` Peter Maydell
2013-12-20 18:53 ` Christoffer Dall
2013-12-17 15:12 ` [Qemu-devel] [PATCH 12/21] target-arm: Remove ARMCPU/CPUARMState from cpregs APIs used by decoder Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 13/21] target-arm: A64: Implement MRS/MSR/SYS/SYSL Peter Maydell
2013-12-19 20:30 ` Richard Henderson
2013-12-20 13:27 ` Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 14/21] target-arm: A64: Implement minimal set of EL0-visible sysregs Peter Maydell
2013-12-19 20:35 ` Richard Henderson
2013-12-21 22:56 ` Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 15/21] target-arm: Widen thread-local register state fields to 64 bits Peter Maydell
2013-12-19 20:53 ` Richard Henderson
2013-12-19 21:04 ` Peter Maydell
2013-12-19 21:09 ` Richard Henderson
2013-12-17 15:12 ` [Qemu-devel] [PATCH 16/21] target-arm: A64: add support for add/sub with carry Peter Maydell
2013-12-19 20:57 ` Richard Henderson
2013-12-17 15:12 ` [Qemu-devel] [PATCH 17/21] target-arm: A64: add support for conditional compare insns Peter Maydell
2013-12-19 21:04 ` Richard Henderson
2013-12-19 21:23 ` Peter Maydell
2013-12-19 21:26 ` Richard Henderson
2013-12-19 21:31 ` Peter Maydell
2013-12-20 16:19 ` Peter Maydell
2013-12-20 16:22 ` Richard Henderson
2013-12-17 15:12 ` [Qemu-devel] [PATCH 18/21] target-arm: aarch64: add support for ld lit Peter Maydell
2013-12-19 21:07 ` Richard Henderson
2013-12-17 15:12 ` [Qemu-devel] [PATCH 19/21] target-arm: Widen exclusive-access support struct fields to 64 bits Peter Maydell
2013-12-17 15:12 ` [Qemu-devel] [PATCH 20/21] target-arm: A64: support for ld/st/cl exclusive Peter Maydell
2013-12-19 21:15 ` Richard Henderson
2013-12-17 15:12 ` [Qemu-devel] [PATCH 21/21] default-configs: Add config for aarch64-linux-user Peter Maydell
2013-12-19 21:15 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B34907.1040109@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=christoffer.dall@linaro.org \
--cc=claudio.fontana@linaro.org \
--cc=dmueller@suse.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=laurent.desnogues@gmail.com \
--cc=matz@suse.de \
--cc=patches@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).