From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55526)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VtjHj-0006lh-6p
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 14:29:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VtjHY-0007M6-O1
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 14:29:27 -0500
Received: from mail-qa0-x22a.google.com ([2607:f8b0:400d:c00::22a]:51753)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VtjHY-0007Lw-JJ
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 14:29:16 -0500
Received: by mail-qa0-f42.google.com with SMTP id k4so5111915qaq.8
	for <qemu-devel@nongnu.org>; Thu, 19 Dec 2013 11:29:16 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B34907.1040109@twiddle.net>
Date: Thu, 19 Dec 2013 11:29:11 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387293144-11554-1-git-send-email-peter.maydell@linaro.org>
	<1387293144-11554-8-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1387293144-11554-8-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 07/21] target-arm: A64: add support for 3
 src data proc insns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/17/2013 07:12 AM, Peter Maydell wrote:
> +    tcg_gen_mul_i64(tcg_tmp, tcg_op1, tcg_op2);
> +    if (is_sub) {
> +        tcg_gen_sub_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp);
> +    } else {
> +        tcg_gen_add_i64(cpu_reg(s, rd), cpu_reg(s, ra), tcg_tmp);
> +    }

Perhaps worth noticing the RA=XZR special case for the MUL alias?

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~