From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53715)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VtkwE-0005uV-No
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 16:15:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vtkw5-0006Lb-6G
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 16:15:22 -0500
Received: from mail-qa0-x229.google.com ([2607:f8b0:400d:c00::229]:56604)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vtkw5-0006LN-27
	for qemu-devel@nongnu.org; Thu, 19 Dec 2013 16:15:13 -0500
Received: by mail-qa0-f41.google.com with SMTP id j5so5221671qaq.7
	for <qemu-devel@nongnu.org>; Thu, 19 Dec 2013 13:15:12 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B361DB.1000801@twiddle.net>
Date: Thu, 19 Dec 2013 13:15:07 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387293144-11554-1-git-send-email-peter.maydell@linaro.org>
	<1387293144-11554-21-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1387293144-11554-21-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 20/21] target-arm: A64: support for
	ld/st/cl exclusive
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/17/2013 07:12 AM, Peter Maydell wrote:
> +    switch (size) {
> +    case 0:
> +        tcg_gen_qemu_ld8u(tmp, addr, get_mem_index(s));
> +        break;
> +    case 1:
> +        tcg_gen_qemu_ld16u(tmp, addr, get_mem_index(s));
> +        break;
> +    case 2:
> +        tcg_gen_qemu_ld32u(tmp, addr, get_mem_index(s));
> +        break;
> +    case 3:
> +        tcg_gen_qemu_ld64(tmp, addr, get_mem_index(s));
> +        break;
> +    default:
> +        abort();
> +    }

tcg_gen_qemu_ld_i64.

> +        if (size == 2) {
> +            tcg_gen_qemu_ld32u(hitmp, addr2, get_mem_index(s));
> +        } else {
> +            tcg_gen_qemu_ld64(hitmp, addr2, get_mem_index(s));
> +        }

Likewise.


r~