From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44118) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtlsn-0005k4-RO for qemu-devel@nongnu.org; Thu, 19 Dec 2013 17:15:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vtlsi-0000gE-W0 for qemu-devel@nongnu.org; Thu, 19 Dec 2013 17:15:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vtlsi-0000g8-Ms for qemu-devel@nongnu.org; Thu, 19 Dec 2013 17:15:48 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rBJMFl3i019113 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 19 Dec 2013 17:15:48 -0500 Message-ID: <52B37012.8010004@redhat.com> Date: Thu, 19 Dec 2013 15:15:46 -0700 From: Eric Blake MIME-Version: 1.0 References: <1387482443-10633-1-git-send-email-mreitz@redhat.com> <1387482443-10633-6-git-send-email-mreitz@redhat.com> In-Reply-To: <1387482443-10633-6-git-send-email-mreitz@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ucCpmwsCDUO85U5o2d1QqSfkcoBxOJxo2" Subject: Re: [Qemu-devel] [PATCH v6 05/22] qemu-option: Add qemu_config_parse_qdict() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Max Reitz , qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , Stefan Hajnoczi This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --ucCpmwsCDUO85U5o2d1QqSfkcoBxOJxo2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 12/19/2013 12:47 PM, Max Reitz wrote: > This function basically parses command-line options given as a QDict > replacing a config file. >=20 > For instance, the QDict {"section.opt1": 42, "section.opt2": 23} > corresponds to the config file: >=20 > [section] > opt1 =3D 42 > opt2 =3D 23 Thanks for the examples; that helped in looking at the code. > Signed-off-by: Max Reitz > --- > include/qemu/config-file.h | 6 +++ > util/qemu-config.c | 95 ++++++++++++++++++++++++++++++++++++++= ++++++++ > 2 files changed, 101 insertions(+) > + > +static void config_parse_qdict_section(QDict *options, QemuOptsList *o= pts, > + Error **errp) > +{ > + > + subopts =3D qemu_opts_create_nofail(opts); You need to rebase this on top of Peter's patches that removed this function in favor of &error_abort. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --ucCpmwsCDUO85U5o2d1QqSfkcoBxOJxo2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJSs3ASAAoJEKeha0olJ0NqDywH/ROYnXq0rJxFejWUTU8RfOgs R9uPUOQUNmmNihurtrO2H9l/4Greil3jJtIAUEtK49iqwFfM9cCTuKjXjO1+bbVO l6V8/Q5gADgAyJqPN9NlIspbfNbSBhcfRZpmzMVxtqOhbb1BGQZwzAz+SfCJzI1O 4Dq54TAUz3FAStchYzuOw2z9DvyAeqnCT8+28zDPK9oPTyBr2j99ZTn+L6MEXuso XEhlkiJuX+RmhHSf3s1CiEtdYzRI+t0V9ZfpcWI/lsD1pf+NCrFNbAUpvyqqcp7U PUfYoFLzjLopvgYb5wMg2PVBenJozTtxYG3+66Q1R4bCUObpKzbhGYocCDbp2b0= =sCFN -----END PGP SIGNATURE----- --ucCpmwsCDUO85U5o2d1QqSfkcoBxOJxo2--