From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47151) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtwOr-0005R2-8Z for qemu-devel@nongnu.org; Fri, 20 Dec 2013 04:29:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtwOi-00035b-Aw for qemu-devel@nongnu.org; Fri, 20 Dec 2013 04:29:41 -0500 Message-ID: <52B40DF2.8020505@redhat.com> Date: Fri, 20 Dec 2013 17:29:22 +0800 From: Fam Zheng MIME-Version: 1.0 References: <1387523131-15647-1-git-send-email-famz@redhat.com> <52B401A0.2010403@msgid.tls.msk.ru> In-Reply-To: <52B401A0.2010403@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] acpi unit-test: Create temporary disk file under /tmp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org, Marcel Apfelbaum On 12/20/13 16:36, Michael Tokarev wrote: > 20.12.2013 11:05, Fam Zheng wrote: >> As other tests, the image file is created in /tmp other than current >> dir. Thus there will not be an unignored file under tests for intree >> build. >> >> Signed-off-by: Fam Zheng >> --- >> tests/acpi-test.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/tests/acpi-test.c b/tests/acpi-test.c >> index ca83b1d6..e4f31b7 100644 >> --- a/tests/acpi-test.c >> +++ b/tests/acpi-test.c >> @@ -116,7 +116,7 @@ static uint8_t boot_sector[0x200] = { >> [0x1FF] = 0xAA, >> }; >> >> -static const char *disk = "tests/acpi-test-disk.raw"; >> +static const char *disk = "/tmp/qtest-acpi-test-disk.raw"; > > Please, PLEASE do NOT do this. > > If you want a temp dir, create one in qemu source directory > (there's no urge to be able to specify one at build/run time, > a symlink created by user will do), -- so that all this junk > will be in a single dir easy to remove. > > But never, ever, use /tmp like this, not here not elsewhere > else. When you use /tmp, first, there's $TEMPDIR, and second, > much more important, there are apis like mkstemp(3) or > tmpfile(3), or tempnam(3), -- THIS is the only proper way to > use common temporary directories. > > Never, ever, create fixed (or even predictable, with getpid() > for example) files in public temporary dirs. Never. > > For this issue, I think a better solution is to actually remove > this file on make clean. Now you're just moving an unignored > file elsewhere, which isn't good by its own. > OK, will take your suggestion. Thanks for explanation. Fam