From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtyGX-0003eI-5p for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:29:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VtyGR-000644-5o for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:29:13 -0500 Received: from cantor2.suse.de ([195.135.220.15]:57292 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VtyGQ-00063y-Vg for qemu-devel@nongnu.org; Fri, 20 Dec 2013 06:29:07 -0500 Message-ID: <52B429FD.3040800@suse.de> Date: Fri, 20 Dec 2013 12:29:01 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1386085320-12965-1-git-send-email-pbonzini@redhat.com> <1386085320-12965-3-git-send-email-pbonzini@redhat.com> <52AE1DBB.9080605@suse.de> <52B2DAA6.5050806@ozlabs.ru> In-Reply-To: <52B2DAA6.5050806@ozlabs.ru> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 2/2] qom: detect bad reentrance during object_class_foreach List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexey Kardashevskiy Cc: Paolo Bonzini , Peter Crosthwaite , =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , "qemu-devel@nongnu.org Developers" , Igor Mammedov Am 19.12.2013 12:38, schrieb Alexey Kardashevskiy: > On 12/16/2013 08:23 AM, Andreas F=C3=A4rber wrote: >> Am 04.12.2013 06:51, schrieb Peter Crosthwaite: >>> On Wed, Dec 4, 2013 at 1:42 AM, Paolo Bonzini w= rote: >>>> From: Herv=C3=A9 Poussineau >>>> >>>> We should not modify the type hash table while it is being iterated = on. >>>> Assert that it does not happen. >>>> >>>> Signed-off-by: Herv=C3=A9 Poussineau >>>> Signed-off-by: Paolo Bonzini >>>> --- >>>> qom/object.c | 4 ++++ >>>> 1 file changed, 4 insertions(+) >>>> >>>> diff --git a/qom/object.c b/qom/object.c >>>> index 3a43186..1dee9f0 100644 >>>> --- a/qom/object.c >>>> +++ b/qom/object.c >>>> @@ -78,8 +78,10 @@ static GHashTable *type_table_get(void) >>>> return type_table; >>>> } >>>> >>>> +static bool enumerating =3D false; >>> >>> Global variable could probably use a more descriptive name. >> >> I renamed it to enumerating_types and dropped the assignment as >> suggested elsewhere by Alexey (a reply here would've been nice!). >=20 > Whose reply? To what? :) A reply of yours to Peter C.'s change request, stating that you have addressed it - and in this case in which series. :) >> I also took the liberty of inserted a white line to make the function >> better readable. >=20 > I do not mind, this was not my stuff :) >=20 > What I wonder about is what is going to happen to the rest of what I > posted? Should I wait till this qom-next gets merged to upstream and re= post > my patches for Alex Graf again? Thanks. I do intend to post a pull before Chistmas, reviewing+applying the last no_user patch from Markus was one key ingredient for that. Not sure which rest exactly you're referring to? I need to review your latest QemuOpts proposal among others. Actually I have a whole A4 page written down with series I'm wading through. ;) Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg