From: Eric Blake <eblake@redhat.com>
To: Hu Tao <hutao@cn.fujitsu.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Lieven <pl@kamp.de>,
Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH v3 1/6] block: introduce prealloc_mode
Date: Fri, 20 Dec 2013 05:36:02 -0700 [thread overview]
Message-ID: <52B439B2.3040603@redhat.com> (raw)
In-Reply-To: <c6cb3e837464999ec730242b62fddca670aeb39e.1387419339.git.hutao@cn.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1049 bytes --]
On 12/18/2013 07:27 PM, Hu Tao wrote:
> This patch prepares for the subsequent patches.
>
> Signed-off-by: Hu Tao <hutao@cn.fujitsu.com>
> ---
> block/qcow2.c | 6 +++---
> include/block/block.h | 6 ++++++
> 2 files changed, 9 insertions(+), 3 deletions(-)
>
> +++ b/include/block/block.h
> @@ -527,4 +527,10 @@ int bdrv_debug_remove_breakpoint(BlockDriverState *bs, const char *tag);
> int bdrv_debug_resume(BlockDriverState *bs, const char *tag);
> bool bdrv_debug_is_suspended(BlockDriverState *bs, const char *tag);
>
> +enum prealloc_mode {
> + PREALLOC_OFF = 0,
> + PREALLOC_METADATA,
> + PREALLOC_FULL,
> +};
Why not make this a QAPI enum:
{ 'enum': 'PreallocMode', 'data': ['off', 'metadata', 'full'] }
After all, this is the sort of thing where we will eventually want to
select the prealloc mode of new files being created by online operations
such as snapshot creation.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]
next prev parent reply other threads:[~2013-12-20 12:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-19 2:27 [Qemu-devel] [RFC PATCH v3 0/6] qemu-img: add preallocation=full Hu Tao
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 1/6] block: introduce prealloc_mode Hu Tao
2013-12-20 10:08 ` Stefan Hajnoczi
2013-12-20 12:36 ` Eric Blake [this message]
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 2/6] block: add BlockDriver.bdrv_preallocate Hu Tao
2013-12-20 10:10 ` Stefan Hajnoczi
2013-12-24 8:31 ` Hu Tao
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 3/6] block/raw-posix: implement bdrv_preallocate Hu Tao
2013-12-20 10:14 ` Stefan Hajnoczi
2013-12-23 1:45 ` Hu Tao
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 4/6] raw-posix: Add full image preallocation option Hu Tao
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 5/6] qcow2: implement bdrv_preallocate Hu Tao
2013-12-20 10:19 ` Stefan Hajnoczi
2013-12-19 2:27 ` [Qemu-devel] [RFC PATCH v3 6/6] qcow2: Add full image preallocation option Hu Tao
2013-12-20 10:21 ` Stefan Hajnoczi
2013-12-20 10:30 ` [Qemu-devel] [RFC PATCH v3 0/6] qemu-img: add preallocation=full Stefan Hajnoczi
2013-12-20 12:54 ` Eric Blake
2013-12-23 1:59 ` Hu Tao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B439B2.3040603@redhat.com \
--to=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=hutao@cn.fujitsu.com \
--cc=kwolf@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).