From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43153)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Vu02S-0007kG-BU
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 08:22:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1Vu02J-00068E-ML
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 08:22:48 -0500
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:51724 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Vu02J-00067v-A7
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 08:22:39 -0500
Message-ID: <52B444DE.1090301@kamp.de>
Date: Fri, 20 Dec 2013 14:23:42 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1387539117-2427-1-git-send-email-pl@kamp.de>
	<20131220130729.GC5905@stefanha-thinkpad.redhat.com>
In-Reply-To: <20131220130729.GC5905@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3] block: add native support for NFS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: kwolf@redhat.com, famz@redhat.com, qemu-devel@nongnu.org, owasserm@redhat.com, ronniesahlberg@gmail.com, pbonzini@redhat.com

On 20.12.2013 14:07, Stefan Hajnoczi wrote:
> On Fri, Dec 20, 2013 at 12:31:57PM +0100, Peter Lieven wrote:
>> - DID NOT add full implementation of bdrv_get_allocated_file_size because
>>    we are not in a coroutine context and I cannot do an async call here.
>>    I could do a sync call if there would be a guarantee that no requests
>>    are in flight. [Stefan]
> Let's discuss in the other email thread where we started.
Okay.
>
>> +static int64_t nfs_client_open(NFSClient *client, const char *filename,
>> +                               int flags, Error **errp)
>> +{
>> +    int ret = -EINVAL;
>> +    URI *uri;
>> +    char *file = NULL, *strp = NULL;
>> +    struct stat st;
>> +
>> +    uri = uri_parse(filename);
>> +    if (!uri) {
>> +        error_setg(errp, "Invalid URL specified.\n");
> \n should not be included in error_setg() messages.
>
>> +        goto fail;
>> +    }
>> +    strp = strrchr(uri->path, '/');
>> +    if (strp == NULL) {
>> +        error_setg(errp, "Invalid URL specified.\n");
> \n should not be included in error_setg() messages.

If thats the only objection you have, please remove the \n
when picking.

Thanks,
Peter