From: Paolo Bonzini <pbonzini@redhat.com>
To: Igor Mammedov <imammedo@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws,
afaerber@suse.de
Subject: Re: [Qemu-devel] [PATCH] test: QOM interface casting
Date: Fri, 20 Dec 2013 16:54:23 +0100 [thread overview]
Message-ID: <52B4682F.7010408@redhat.com> (raw)
In-Reply-To: <1387545971-22218-1-git-send-email-imammedo@redhat.com>
Il 20/12/2013 14:26, Igor Mammedov ha scritto:
> index 379cdd9..89f8eff 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -52,6 +52,8 @@ check-unit-y += tests/test-int128$(EXESUF)
> gcov-files-test-int128-y =
> check-unit-y += tests/test-bitops$(EXESUF)
> check-unit-y += tests/test-qdev-global-props$(EXESUF)
> +check-unit-y = tests/check-qom-interface$(EXESUF)
> +gcov-files-check-qdict-y = object/object.c
The "=" needs to be a "+=" and the gcov-files-check-qdict-y variable is
wrong (both in name and in content; it should be qom/object.c).
The test itself is good and, as you mentioned on IRC, spots a bug.
Paolo
>
> check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh
prev parent reply other threads:[~2013-12-20 15:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 13:26 [Qemu-devel] [PATCH] test: QOM interface casting Igor Mammedov
2013-12-20 13:30 ` Peter Maydell
2013-12-20 13:58 ` Andreas Färber
2013-12-20 14:08 ` Igor Mammedov
2013-12-20 21:27 ` Peter Crosthwaite
2013-12-20 15:14 ` Igor Mammedov
2013-12-20 15:56 ` Paolo Bonzini
2013-12-20 15:54 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B4682F.7010408@redhat.com \
--to=pbonzini@redhat.com \
--cc=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).