From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53128)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vu2PL-0007EA-Lo
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:54:42 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vu2PE-00034M-9c
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:54:35 -0500
Received: from mail-ee0-x22a.google.com ([2a00:1450:4013:c00::22a]:44899)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vu2PD-000347-Tt
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 10:54:28 -0500
Received: by mail-ee0-f42.google.com with SMTP id e53so1138676eek.15
	for <qemu-devel@nongnu.org>; Fri, 20 Dec 2013 07:54:27 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52B4682F.7010408@redhat.com>
Date: Fri, 20 Dec 2013 16:54:23 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1387545971-22218-1-git-send-email-imammedo@redhat.com>
In-Reply-To: <1387545971-22218-1-git-send-email-imammedo@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] test: QOM interface casting
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, anthony@codemonkey.ws, afaerber@suse.de

Il 20/12/2013 14:26, Igor Mammedov ha scritto:
> index 379cdd9..89f8eff 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -52,6 +52,8 @@ check-unit-y += tests/test-int128$(EXESUF)
>  gcov-files-test-int128-y =
>  check-unit-y += tests/test-bitops$(EXESUF)
>  check-unit-y += tests/test-qdev-global-props$(EXESUF)
> +check-unit-y = tests/check-qom-interface$(EXESUF)
> +gcov-files-check-qdict-y = object/object.c

The "=" needs to be a "+=" and the gcov-files-check-qdict-y variable is
wrong (both in name and in content; it should be qom/object.c).

The test itself is good and, as you mentioned on IRC, spots a bug.

Paolo

>  
>  check-block-$(CONFIG_POSIX) += tests/qemu-iotests-quick.sh