From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33226)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vu2qE-0000qD-VC
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 11:22:31 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vu2q6-0003mb-Gx
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 11:22:22 -0500
Received: from mail-qa0-x234.google.com ([2607:f8b0:400d:c00::234]:58842)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vu2q6-0003mV-C4
	for qemu-devel@nongnu.org; Fri, 20 Dec 2013 11:22:14 -0500
Received: by mail-qa0-f52.google.com with SMTP id cm18so2774252qab.4
	for <qemu-devel@nongnu.org>; Fri, 20 Dec 2013 08:22:13 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B46EB0.80807@twiddle.net>
Date: Fri, 20 Dec 2013 08:22:08 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387293144-11554-1-git-send-email-peter.maydell@linaro.org>
	<1387293144-11554-18-git-send-email-peter.maydell@linaro.org>
	<52B35F6D.9050809@twiddle.net>
	<CAFEAcA9QZiqqiHLDdwK2ZJTfx4RB0o=7CKx7fkzxtcmUW6=SyQ@mail.gmail.com>
In-Reply-To: <CAFEAcA9QZiqqiHLDdwK2ZJTfx4RB0o=7CKx7fkzxtcmUW6=SyQ@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 17/21] target-arm: A64: add support for
 conditional compare insns
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Patch Tracking <patches@linaro.org>, Michael Matz <matz@suse.de>, QEMU Developers <qemu-devel@nongnu.org>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, "kvmarm@lists.cs.columbia.edu" <kvmarm@lists.cs.columbia.edu>, Christoffer Dall <christoffer.dall@linaro.org>

On 12/20/2013 08:19 AM, Peter Maydell wrote:
> Is it worth pulling the assignment
>   label_continue = gen_new_label();
> out of the if() to protect against possible less smart compilers?

Sure.  Or even initializing to -1.


r~