From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55770) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vutkq-0004K1-BJ for qemu-devel@nongnu.org; Sun, 22 Dec 2013 19:52:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vutkj-0003dz-2M for qemu-devel@nongnu.org; Sun, 22 Dec 2013 19:52:20 -0500 Received: from mout.web.de ([212.227.15.14]:55154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vutki-0003dq-Pt for qemu-devel@nongnu.org; Sun, 22 Dec 2013 19:52:12 -0500 Received: from envy.site ([89.158.68.43]) by smtp.web.de (mrweb103) with ESMTPSA (Nemesis) id 0LoYb8-1VIpAe01da-00gam2 for ; Mon, 23 Dec 2013 01:52:10 +0100 Message-ID: <52B78939.3080809@web.de> Date: Mon, 23 Dec 2013 01:52:09 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1383606592-12783-1-git-send-email-hpoussin@reactos.org> In-Reply-To: <1383606592-12783-1-git-send-email-hpoussin@reactos.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v3 00/10] prep: improve Raven PCI host emulation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?SGVydsOpIFBvdXNzaW5lYXU=?= , qemu-devel@nongnu.org Cc: Paolo Bonzini , qemu-ppc@nongnu.org, Anthony Liguori , "Michael S. Tsirkin" Am 05.11.2013 00:09, schrieb Hervé Poussineau: > Hervé Poussineau (10): > prep: kill get_system_io() usage > raven: use constant PCI_NUM_PINS instead of 4 Thanks and sorry for the delay, I've applied these to prep-up: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/prep-up (An intermittent memory'ish regression has been fixed now apparently.) > raven: move BIOS loading from board code to PCI host Hearing no objections or comments on this approach of loading firmware in the PCI host bridge device, we have discussed that I'll be accepting it to allow for easy sharing between in-tree and upcoming PReP machines. However I'm still struggling to understand another aspect of the patch, question inline. Regards, Andreas > raven: rename intack region to pci_intack > raven: set a correct PCI I/O memory region > raven: set a correct PCI memory region > raven: add PCI bus mastering address space > raven: implement non-contiguous I/O region > raven: fix PCI bus accesses with size > 1 > raven: use raven_ for all function prefixes > > hw/pci-host/prep.c | 235 ++++++++++++++++++++++++++++++++++++++++++++-------- > hw/ppc/prep.c | 155 ++++++---------------------------- > 2 files changed, 226 insertions(+), 164 deletions(-) >