From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: John Rigby <john.rigby@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
Alexander Graf <agraf@suse.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Laszlo Ersek <lersek@redhat.com>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora
Date: Mon, 23 Dec 2013 13:50:52 +0100 [thread overview]
Message-ID: <52B831AC.8030207@redhat.com> (raw)
In-Reply-To: <CAFEAcA-=9j86Eo8sjtBojuQti=ti9_o5CjZO+QAONye5ZjuXRw@mail.gmail.com>
Il 23/12/2013 13:37, Peter Maydell ha scritto:
> At a minimum, if we take this approach we should add TODO comments
> to the effect that the NULL terminator and the if() can be removed
> when the first real AArch64 CPU is added.
>
> I think I'd rather put the if (!info->name) continue into the function
> which is doing the looping over the array.
Or just change the termination condition from a check on the array size
to one on info->name.
Paolo
next prev parent reply other threads:[~2013-12-23 12:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-23 11:56 [Qemu-devel] [PATCH] target-arm: fix build on fedora Michael S. Tsirkin
2013-12-23 12:37 ` Peter Maydell
2013-12-23 12:50 ` Paolo Bonzini [this message]
2013-12-23 12:59 ` Peter Maydell
2013-12-23 13:32 ` Stefan Weil
2013-12-23 13:41 ` Peter Maydell
2013-12-23 14:15 ` Michael S. Tsirkin
2013-12-23 14:15 ` Peter Maydell
2013-12-23 13:45 ` Andreas Färber
2013-12-23 13:56 ` Peter Maydell
2013-12-23 14:16 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B831AC.8030207@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=john.rigby@linaro.org \
--cc=lersek@redhat.com \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).