From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv4yT-0007DP-T3 for qemu-devel@nongnu.org; Mon, 23 Dec 2013 07:51:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vv4yL-0002K8-Fr for qemu-devel@nongnu.org; Mon, 23 Dec 2013 07:51:09 -0500 Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:50667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv4yL-0002K3-83 for qemu-devel@nongnu.org; Mon, 23 Dec 2013 07:51:01 -0500 Received: by mail-ee0-f52.google.com with SMTP id d17so2288620eek.25 for ; Mon, 23 Dec 2013 04:50:59 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52B831AC.8030207@redhat.com> Date: Mon, 23 Dec 2013 13:50:52 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <20131223115622.GA6490@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] target-arm: fix build on fedora List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: John Rigby , "Michael S. Tsirkin" , Alexander Graf , QEMU Developers , Laszlo Ersek , Richard Henderson Il 23/12/2013 13:37, Peter Maydell ha scritto: > At a minimum, if we take this approach we should add TODO comments > to the effect that the NULL terminator and the if() can be removed > when the first real AArch64 CPU is added. > > I think I'd rather put the if (!info->name) continue into the function > which is doing the looping over the array. Or just change the termination condition from a check on the array size to one on info->name. Paolo