From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35613)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvBVn-00020H-UG
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 14:50:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvBVj-0001fa-7x
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 14:49:59 -0500
Received: from mail-pb0-x234.google.com ([2607:f8b0:400e:c01::234]:52365)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvBVi-0001f6-W5
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 14:49:55 -0500
Received: by mail-pb0-f52.google.com with SMTP id uo5so5632850pbc.39
	for <qemu-devel@nongnu.org>; Mon, 23 Dec 2013 11:49:52 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B893DB.7070108@twiddle.net>
Date: Mon, 23 Dec 2013 11:49:47 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387752607-23755-1-git-send-email-peter.maydell@linaro.org>
	<1387752607-23755-2-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1387752607-23755-2-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH v2 01/25] target-arm: A64: add support for
	ld/st pair
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?UTF-8?B?QWxleCBCZW5uw6ll?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/22/2013 02:49 PM, Peter Maydell wrote:
> This patch support the basic load and store pair instructions and
> includes the generic helper functions:
> 
>   * do_gpr_st()
>   * do_fp_st()
>   * do_gpr_ld()
>   * do_fp_ld()
>   * read_cpu_reg_sp()
>   * gen_check_sp_alignment()
> 
> The last function gen_check_sp_alignment() is a NULL op currently but
> put in place to make it easy to add SP alignment checking later.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-arm/translate-a64.c | 279 ++++++++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 277 insertions(+), 2 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~