From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36010)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvBXD-00038n-EO
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 14:51:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvBX5-0002Ad-Sp
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 14:51:27 -0500
Received: from mail-pb0-x232.google.com ([2607:f8b0:400e:c01::232]:50658)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvBX5-0002AZ-Ix
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 14:51:19 -0500
Received: by mail-pb0-f50.google.com with SMTP id rr13so5639156pbb.37
	for <qemu-devel@nongnu.org>; Mon, 23 Dec 2013 11:51:18 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B89433.9070400@twiddle.net>
Date: Mon, 23 Dec 2013 11:51:15 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387752607-23755-1-git-send-email-peter.maydell@linaro.org>
	<1387752607-23755-12-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1387752607-23755-12-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 11/25] target-arm: Pull "add one cpreg
 to hashtable" into its own function
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/22/2013 02:49 PM, Peter Maydell wrote:
> define_one_arm_cp_reg_with_opaque() has a set of nested loops which
> insert a cpreg entry into the hashtable for each of the possible
> opc/crn/crm values allowed by wildcard specifications. We're about
> to add an extra loop to this nesting, so pull the core of the loop
> (which adds a single entry to the hashtable) out into its own
> function for clarity.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-arm/helper.c | 94 +++++++++++++++++++++++++++++------------------------
>  1 file changed, 52 insertions(+), 42 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~