From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:58534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvDFf-0001My-Ht
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 16:41:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvDFa-0000TB-QL
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 16:41:27 -0500
Received: from mail-pa0-x231.google.com ([2607:f8b0:400e:c03::231]:37921)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvDFa-0000Sz-ID
	for qemu-devel@nongnu.org; Mon, 23 Dec 2013 16:41:22 -0500
Received: by mail-pa0-f49.google.com with SMTP id kx10so5691714pab.8
	for <qemu-devel@nongnu.org>; Mon, 23 Dec 2013 13:41:21 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B8ADFD.80602@twiddle.net>
Date: Mon, 23 Dec 2013 13:41:17 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387752607-23755-1-git-send-email-peter.maydell@linaro.org>
	<1387752607-23755-23-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1387752607-23755-23-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 22/25] linux-user: AArch64: define
	TARGET_CLONE_BACKWARDS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/22/2013 02:50 PM, Peter Maydell wrote:
> From: Claudio Fontana <claudio.fontana@linaro.org>
> 
> The AArch64 linux-user support was written before but merged after
> commit 4ce6243dc621 which cleaned up the handling of the clone()
> syscall argument order, so we failed to notice that AArch64 also needs
> TARGET_CLONE_BACKWARDS to be defined. Add this define so that clone
> and fork syscalls work correctly.
> 
> Signed-off-by: Claudio Fontana <claudio.fontana@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  linux-user/aarch64/syscall.h | 1 +
>  1 file changed, 1 insertion(+)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~