From: "Andreas Färber" <afaerber@suse.de>
To: Igor Mammedov <imammedo@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, armbru@redhat.com, anthony@codemonkey.ws
Subject: Re: [Qemu-devel] [PATCH v2] test: QOM interface casting
Date: Tue, 24 Dec 2013 01:21:05 +0100 [thread overview]
Message-ID: <52B8D371.3090804@suse.de> (raw)
In-Reply-To: <1387574080-15169-1-git-send-email-imammedo@redhat.com>
Am 20.12.2013 22:14, schrieb Igor Mammedov:
> Add basic regression testing for QOM Interface usage.
> Test checks casting to interface type/class for following cases:
> - interface implementation in leaf class
> - interface implementation in intermediate (parent) class
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> - Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> * s/Parent/parent_obj/
> * s/parent/parent_class/
> - Peter Maydell <peter.maydell@linaro.org>
> * s/interfacei/interface/
> * s/OQM/QOM/ typo
> * tests/Makefile split too long line
> - Andreas Färber <afaerber@suse.de>
> * consolidate QOM core object files in dedicated variable
> * add SoB and commit message
> * fix copy/past errors in tests/Makefile
> * prefix test names with "/qom/interface/"
> * s/ico/ioc/
> * add extra spacing
> ---
> tests/Makefile | 6 ++-
> tests/check-qom-interface.c | 105 +++++++++++++++++++++++++++++++++++++++++++
> 2 files changed, 110 insertions(+), 1 deletions(-)
> create mode 100644 tests/check-qom-interface.c
Thanks, queued after the squashed interface fixes:
https://github.com/afaerber/qemu-cpu/commits/qom-next
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
prev parent reply other threads:[~2013-12-24 0:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 21:14 [Qemu-devel] [PATCH v2] test: QOM interface casting Igor Mammedov
2013-12-24 0:21 ` Andreas Färber [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B8D371.3090804@suse.de \
--to=afaerber@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=imammedo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).