From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvQ81-00039q-UF for qemu-devel@nongnu.org; Tue, 24 Dec 2013 06:26:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvQ7w-0001jK-2T for qemu-devel@nongnu.org; Tue, 24 Dec 2013 06:26:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:50964 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvQ7v-0001jG-SJ for qemu-devel@nongnu.org; Tue, 24 Dec 2013 06:26:19 -0500 Message-ID: <52B96F57.8030007@suse.de> Date: Tue, 24 Dec 2013 12:26:15 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1387576494-20466-1-git-send-email-pbonzini@redhat.com> <52B8D2F1.70908@suse.de> <52B96D55.50703@redhat.com> In-Reply-To: <52B96D55.50703@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] qom: fix inherited interfaces List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Igor Mammedov , peter.crosthwaite@xilinx.com, qemu-devel@nongnu.org Am 24.12.2013 12:17, schrieb Paolo Bonzini: > Il 24/12/2013 01:18, Andreas F=E4rber ha scritto: >> Thanks, I have squashed it, but I would appreciate if someone more >> familiar with interfaces could take a quick look at my commit message >> before I send a PULL tomorrow. Should I drop Reported-by during squash= ? >> >> https://github.com/afaerber/qemu-cpu/commits/qom-next >=20 > I think it can be left in because the subclass::superclass::interface > bug was pre-existing. Here is a better wording: >=20 > qom: Do not register interface "types" in the type table and fix names >=20 > There should be no need to look them up nor enumerate the interface > "types", whose "classes" are really just vtables. Just create the > types and add them to the interface list of the parent type. >=20 > Interfaces not registering their type anymore means that accessing > superclass::interface by type name will fail when initializing > subclass::interface. Thus, we need to pre-initialize the subclass's > parent_type field before calling type_initialize. Apart from this, the > interface "types" should never be used and thus it is harmless to leave > them out of the hashtable. >=20 > Further, the interface types had a bug with interfaces that are > inherited from a superclass: The implementation type name was wrong > (for example it was subclass::superclass::interface rather than > just subclass::interface). This patch fixes this as well. >=20 > Reported-by: Igor Mammedov > Tested-by: Igor Mammedov > Signed-off-by: Paolo Bonzini Thanks a lot, updated with one minor change: The initial "them" is now ambiguous (types vs. names), so I've dropped it since the sentence ends in "types" anyway. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg