From: Richard Henderson <rth@twiddle.net>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 1/9] target-sh4: use bit number for SR constants
Date: Tue, 24 Dec 2013 06:10:41 -0800 [thread overview]
Message-ID: <52B995E1.7060409@twiddle.net> (raw)
In-Reply-To: <1387713039-9584-2-git-send-email-aurelien@aurel32.net>
On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
> Use the bit number for SR constants instead of using a bit mask. This
> make possible to also use the constants for shifts.
>
> Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> ---
> target-sh4/cpu.c | 3 +-
> target-sh4/cpu.h | 30 +++++++++----------
> target-sh4/gdbstub.c | 4 +--
> target-sh4/helper.c | 27 ++++++++---------
> target-sh4/op_helper.c | 26 ++++++++---------
> target-sh4/translate.c | 75 +++++++++++++++++++++++++-----------------------
> 6 files changed, 85 insertions(+), 80 deletions(-)
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2013-12-24 14:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-22 11:50 [Qemu-devel] [PATCH v2 0/9] target-sh4: optimizations and cleanups Aurelien Jarno
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 1/9] target-sh4: use bit number for SR constants Aurelien Jarno
2013-12-24 14:10 ` Richard Henderson [this message]
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 2/9] target-sh4: Split out T from SR Aurelien Jarno
2013-12-24 14:13 ` Richard Henderson
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 3/9] target-sh4: optimize addc using add2 Aurelien Jarno
2013-12-24 14:18 ` Richard Henderson
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 4/9] target-sh4: optimize subc using sub2 Aurelien Jarno
2013-12-24 14:22 ` Richard Henderson
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 5/9] target-sh4: optimize negc using add2 and sub2 Aurelien Jarno
2013-12-24 14:25 ` Richard Henderson
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 6/9] target-sh4: split out Q and M from of SR and optimize div1 Aurelien Jarno
2013-12-24 14:44 ` Richard Henderson
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 7/9] target-sh4: factorize fmov implementation Aurelien Jarno
2013-12-24 14:46 ` Richard Henderson
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 8/9] target-sh4: remove dead code Aurelien Jarno
2013-12-24 14:46 ` Richard Henderson
2013-12-22 11:50 ` [Qemu-devel] [PATCH v2 9/9] target-sh4: simplify tas instruction Aurelien Jarno
2013-12-24 14:49 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B995E1.7060409@twiddle.net \
--to=rth@twiddle.net \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).