From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:40007)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvSkD-0000v4-1Y
	for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:14:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvSk7-0002Fo-6B
	for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:14:00 -0500
Received: from mail-pa0-x229.google.com ([2607:f8b0:400e:c03::229]:37583)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VvSk6-0002Fh-VF
	for qemu-devel@nongnu.org; Tue, 24 Dec 2013 09:13:55 -0500
Received: by mail-pa0-f41.google.com with SMTP id lf10so6583105pab.14
	for <qemu-devel@nongnu.org>; Tue, 24 Dec 2013 06:13:54 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52B9969E.7020900@twiddle.net>
Date: Tue, 24 Dec 2013 06:13:50 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1387713039-9584-1-git-send-email-aurelien@aurel32.net>
	<1387713039-9584-3-git-send-email-aurelien@aurel32.net>
In-Reply-To: <1387713039-9584-3-git-send-email-aurelien@aurel32.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 2/9] target-sh4: Split out T from SR
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>, qemu-devel@nongnu.org

On 12/22/2013 03:50 AM, Aurelien Jarno wrote:
> +static inline target_ulong cpu_read_sr(CPUSH4State *env)
> +{
> +    return (env->sr & ~(1u << SR_T)) | (env->sr_t << SR_T);
> +}
> +
> +static inline void cpu_write_sr(CPUSH4State *env, target_ulong sr)
> +{
> +    env->sr_t = sr & (1u << SR_T);
> +    env->sr = sr & ~(1u << SR_T);
> +}
...
> +static void gen_read_sr(TCGv dst)
> +{
> +    tcg_gen_andi_i32(dst, cpu_sr, ~(1u << SR_T));
> +    tcg_gen_or_i32(dst, dst, cpu_sr_t);
> +}
> +
> +static void gen_write_sr(TCGv src)
> +{
> +    tcg_gen_andi_i32(cpu_sr, src, ~(1u << SR_T));
> +    tcg_gen_andi_i32(cpu_sr_t, src, (1u << SR_T));
> +}

If the writer always clears SR_T when assigning to env->sr,
then there's no need to clear it when reading from env->sr.
Or vice versa.

Otherwise,

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~