From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvTxB-0000BH-Gy for qemu-devel@nongnu.org; Tue, 24 Dec 2013 10:31:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvTx5-00011H-K7 for qemu-devel@nongnu.org; Tue, 24 Dec 2013 10:31:29 -0500 Sender: Richard Henderson Message-ID: <52B9A8C6.5070709@twiddle.net> Date: Tue, 24 Dec 2013 07:31:18 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1387399747-4994-1-git-send-email-tommusta@gmail.com> <1387399747-4994-8-git-send-email-tommusta@gmail.com> In-Reply-To: <1387399747-4994-8-git-send-email-tommusta@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V3 PATCH 07/14] target-ppc: Add ISA 2.06 stbcx. and sthcx. Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 12/18/2013 12:49 PM, Tom Musta wrote: > This patch adds the byte and halfword variants of the Store Conditional > instructions. A common macro is introduced and the existing implementations > of stwcx. and stdcx. are re-implemented using this macro. > > V2: Re-implemented gen_conditional_store() and STCX macro per comments > from Richard. > > Signed-off-by: Tom Musta > --- > target-ppc/translate.c | 88 ++++++++++++++++++++++------------------------- > 1 files changed, 41 insertions(+), 47 deletions(-) Reviewed-by: Richard Henderson r~