From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvU1o-0001ah-VD for qemu-devel@nongnu.org; Tue, 24 Dec 2013 10:36:22 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvU1j-0002Mc-41 for qemu-devel@nongnu.org; Tue, 24 Dec 2013 10:36:16 -0500 Sender: Richard Henderson Message-ID: <52B9A9E5.3060206@twiddle.net> Date: Tue, 24 Dec 2013 07:36:05 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1387399747-4994-1-git-send-email-tommusta@gmail.com> <1387399747-4994-9-git-send-email-tommusta@gmail.com> In-Reply-To: <1387399747-4994-9-git-send-email-tommusta@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [V3 PATCH 08/14] target-ppc: Add ISA2.06 Float to Integer Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 12/18/2013 12:49 PM, Tom Musta wrote: > This patch adds the four floating point to integer conversion instructions > introduced by Power ISA V2.06: > > - Floating Convert to Integer Word Unsigned (fctiwu) > - Floating Convert to Integer Word Unsigned with Round Toward > Zero (fctiwuz) > - Floating Convert to Integer Doubleword Unsigned (fctidu) > - Floating Convert to Integer Doubleword Unsigned with Round > Toward Zero (fctiduz) > > A common macro is developed to eliminate repetitive code. Existing instructions > are also re-implemented to use this macro (fctiw, fctiwz, fctid, fctidz), thus > eliminating copy/paste code. > > Signed-off-by: Tom Musta > --- > target-ppc/fpu_helper.c | 122 +++++++++++++---------------------------------- > target-ppc/helper.h | 4 ++ > target-ppc/translate.c | 12 +++++ > 3 files changed, 50 insertions(+), 88 deletions(-) Reviewed-by: Richard Henderson r~