From: Li Guang <lig.fnst@cn.fujitsu.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Igor Mitsyanko <i.mitsyanko@gmail.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw
Date: Thu, 26 Dec 2013 08:22:03 +0800 [thread overview]
Message-ID: <52BB76AB.3060502@cn.fujitsu.com> (raw)
In-Reply-To: <CAFEAcA-a_0w=NNF+cD53Cf5DOQ0KeeE5GD+ug3qKMH=M99mBfg@mail.gmail.com>
Peter Maydell wrote:
> On 25 December 2013 07:21, liguang<lig.fnst@cn.fujitsu.com> wrote:
>
> This is where your patch should have had an explanation
> for why you're making this change. What is the user outside
> of hw/sd/ that needs this header that means we should
> move it into include/ ?
>
>
I don't mean someone will include it outside of hw/sd, just in the
sense of "header files be better in a directory called include",
A10's SDHC(really an odd controller, without public datasheet) emulation
will use some of definitions in this file, and I think many other standard
SDHC will also be happy to include this file.
next prev parent reply other threads:[~2013-12-26 0:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-25 7:21 [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw liguang
2013-12-25 9:33 ` Peter Maydell
2013-12-26 0:22 ` Li Guang [this message]
2013-12-26 0:36 ` Peter Maydell
2013-12-26 0:40 ` Li Guang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52BB76AB.3060502@cn.fujitsu.com \
--to=lig.fnst@cn.fujitsu.com \
--cc=i.mitsyanko@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).