From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35706) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vvyjz-0000jq-2Q for qemu-devel@nongnu.org; Wed, 25 Dec 2013 19:23:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vvyju-0004W7-Fa for qemu-devel@nongnu.org; Wed, 25 Dec 2013 19:23:54 -0500 Message-ID: <52BB76AB.3060502@cn.fujitsu.com> Date: Thu, 26 Dec 2013 08:22:03 +0800 From: Li Guang MIME-Version: 1.0 References: <1387956078-10651-1-git-send-email-lig.fnst@cn.fujitsu.com> In-Reply-To: Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=UTF-8; format=flowed Subject: Re: [Qemu-devel] [PATCH] hw/sd: move sdhci.h to include/hw List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Peter Crosthwaite , QEMU Trivial , QEMU Developers , Igor Mitsyanko , Stefan Hajnoczi , Paolo Bonzini Peter Maydell wrote: > On 25 December 2013 07:21, liguang wrote: > > This is where your patch should have had an explanation > for why you're making this change. What is the user outside > of hw/sd/ that needs this header that means we should > move it into include/ ? > > I don't mean someone will include it outside of hw/sd, just in the sense of "header files be better in a directory called include", A10's SDHC(really an odd controller, without public datasheet) emulation will use some of definitions in this file, and I think many other standard SDHC will also be happy to include this file.