From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54078) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vw2G5-00006h-1f for qemu-devel@nongnu.org; Wed, 25 Dec 2013 23:09:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vw2Fw-0005hT-4A for qemu-devel@nongnu.org; Wed, 25 Dec 2013 23:09:16 -0500 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:44659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vw2Fv-0005hJ-FC for qemu-devel@nongnu.org; Wed, 25 Dec 2013 23:09:08 -0500 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 26 Dec 2013 14:08:58 +1000 Received: from d23relay03.au.ibm.com (d23relay03.au.ibm.com [9.190.235.21]) by d23dlp02.au.ibm.com (Postfix) with ESMTP id 2019E2BB002D for ; Thu, 26 Dec 2013 15:08:56 +1100 (EST) Received: from d23av03.au.ibm.com (d23av03.au.ibm.com [9.190.234.97]) by d23relay03.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id rBQ48h3964094236 for ; Thu, 26 Dec 2013 15:08:43 +1100 Received: from d23av03.au.ibm.com (localhost [127.0.0.1]) by d23av03.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id rBQ48twH030754 for ; Thu, 26 Dec 2013 15:08:55 +1100 Message-ID: <52BBABDB.30303@linux.vnet.ibm.com> Date: Thu, 26 Dec 2013 12:08:59 +0800 From: Wenchao Xia MIME-Version: 1.0 References: <1386940979-3824-1-git-send-email-kwolf@redhat.com> <1386940979-3824-11-git-send-email-kwolf@redhat.com> In-Reply-To: <1386940979-3824-11-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 10/24] block: Introduce bdrv_co_do_preadv() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, pl@kamp.de, stefanha@redhat.com > /* throttling disk I/O */ > if (bs->io_limits_enabled) { > - bdrv_io_limits_intercept(bs, nb_sectors, false); > + bdrv_io_limits_intercept(bs, bytes >> BDRV_SECTOR_BITS, false); > + } Is it possible (bytes >> BDRV_SECTOR_BITS) == 0? >