Re: [Qemu-devel] [PATCH] discard rbd error output when not relevant in qemu-iotests

[Loic Dachary <loic@dachary.org>]

[-- Attachment #1: Type: text/plain, Size: 1625 bytes --]

Hi Benoît,

If I understand correctly common.filter is designed to transform the output and remove variance. In the case of rbd displaying the progress of removal, it is something we probably want to get rid of entirely. Please let me know if I'm missing something and I'll update the patch according to your suggestion.

Cheers

On 30/12/2013 01:39, Benoît Canet wrote:
> Le Monday 30 Dec 2013 à 01:33:34 (+0100), Loic Dachary a écrit :
>> Stash the rbd stderr and stdout because it also contains human readable
>> progress messages : Removing image: 3% complete... in addition to
>> potential error messages.
>>
>> Display the stashed output if rbd exits on error.
>>
>> Signed-off-by: Loic Dachary <loic@dachary.org>
>> ---
>>  tests/qemu-iotests/common.rc | 6 +++++-
>>  1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
>> index 28ba0d9..af66bbd 100644
>> --- a/tests/qemu-iotests/common.rc
>> +++ b/tests/qemu-iotests/common.rc
>> @@ -189,7 +189,11 @@ _cleanup_test_img()
>>              ;;
>>  
>>          rbd)
>> -            rbd rm "$TEST_DIR/t.$IMGFMT" > /dev/null
>> +            if ! rbd rm "$TEST_DIR/t.$IMGFMT" > $TEST_DIR/rbd.out 2>&1
>> +            then
>> +                cat $TEST_DIR/rbd.out
>> +            fi
>> +            rm $TEST_DIR/rbd.out
>>              ;;
>>  
>>          sheepdog)
> 
> Hi Loïc,
> 
> Maybe you could filter by modifying _filter_qemu_io.
> 
> Best regards
> 
> Benoît
>> -- 
>> 1.8.3.2
>>
>>
> 
> 
> 

-- 
Loïc Dachary, Artisan Logiciel Libre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]