From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39882)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VxeO3-0003q8-4P
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 10:04:15 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VxeNy-0002x4-4P
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 10:04:11 -0500
Received: from mail-qc0-x231.google.com ([2607:f8b0:400d:c01::231]:58803)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VxeNy-0002wz-18
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 10:04:06 -0500
Received: by mail-qc0-f177.google.com with SMTP id m20so10827438qcx.36
	for <qemu-devel@nongnu.org>; Mon, 30 Dec 2013 07:04:05 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52C18B60.7020102@twiddle.net>
Date: Mon, 30 Dec 2013 07:04:00 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1388267351-31818-1-git-send-email-peter.maydell@linaro.org>
	<1388267351-31818-4-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1388267351-31818-4-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/10] target-arm: Use VFP_BINOP macro for
 min, max, minnum, maxnum
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/28/2013 01:49 PM, Peter Maydell wrote:
> Use the VFP_BINOP macro to provide helpers for min, max, minnum
> and maxnum, rather than hand-rolling them. (The float64 max
> version is not used by A32 but will be needed for A64.)
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-arm/helper.c      | 29 ++++-------------------------
>  target-arm/helper.h      | 15 ++++++++-------
>  target-arm/neon_helper.c | 12 ------------
>  target-arm/translate.c   | 16 ++++++++--------
>  4 files changed, 20 insertions(+), 52 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~