From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:44615)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VxemY-0000BI-45
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 10:29:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VxemT-0001z7-R1
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 10:29:30 -0500
Received: from mail-qc0-x234.google.com ([2607:f8b0:400d:c01::234]:41833)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1VxemT-0001z2-MT
	for qemu-devel@nongnu.org; Mon, 30 Dec 2013 10:29:25 -0500
Received: by mail-qc0-f180.google.com with SMTP id w7so11051894qcr.11
	for <qemu-devel@nongnu.org>; Mon, 30 Dec 2013 07:29:25 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52C19150.9080501@twiddle.net>
Date: Mon, 30 Dec 2013 07:29:20 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1388267351-31818-1-git-send-email-peter.maydell@linaro.org>
	<1388267351-31818-11-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1388267351-31818-11-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 10/10] target-arm: Give the FPSCR rounding
 modes names
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Laurent Desnogues <laurent.desnogues@gmail.com>, patches@linaro.org, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/28/2013 01:49 PM, Peter Maydell wrote:
> From: Alexander Graf <agraf@suse.de>
> 
> When setting rounding modes we currently just hardcode the numeric values
> for rounding modes in a big switch statement.
> 
> With AArch64 support coming, we will need to refer to these rounding modes
> at different places throughout the code though, so let's better give them
> names so we don't get confused by accident.
> 
> Signed-off-by: Alexander Graf <agraf@suse.de>
> [WN: Commit message tweak, use names from ARM ARM.]
> Signed-off-by: Will Newton <will.newton@linaro.org>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-arm/cpu.h    | 9 +++++++++
>  target-arm/helper.c | 8 ++++----
>  2 files changed, 13 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~