From: Richard Henderson <rth@twiddle.net>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Tom Musta" <tommusta@gmail.com>,
"Peter Crosthwaite" <peter.crosthwaite@xilinx.com>,
patches@linaro.org, "Aurelien Jarno" <aurelien@aurel32.net>,
"Michael Matz" <matz@suse.de>, "Alexander Graf" <agraf@suse.de>,
"Claudio Fontana" <claudio.fontana@linaro.org>,
"Dirk Mueller" <dmueller@suse.de>,
"Will Newton" <will.newton@linaro.org>,
"Laurent Desnogues" <laurent.desnogues@gmail.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
kvmarm@lists.cs.columbia.edu,
"Christoffer Dall" <christoffer.dall@linaro.org>
Subject: Re: [Qemu-devel] [PATCH 02/22] softfloat: Add float to 16bit integer conversions.
Date: Tue, 31 Dec 2013 06:18:35 -0800 [thread overview]
Message-ID: <52C2D23B.4050309@twiddle.net> (raw)
In-Reply-To: <1388496958-3542-3-git-send-email-peter.maydell@linaro.org>
On 12/31/2013 05:35 AM, Peter Maydell wrote:
> + int64_t v;
> + int_fast16_t res;
> + int old_exc_flags = get_float_exception_flags(status);
> +
> + v = float32_to_int64(a STATUS_VAR);
Any good reason not to use int32 as the intermediate, for the benefit of 32-bit
hosts?
Otherwise,
Reviewed-by: Richard Henderson <rth@twiddle.net>
r~
next prev parent reply other threads:[~2013-12-31 14:18 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 13:35 [Qemu-devel] [PATCH 00/22] A64 decoder patchset 6: rest of floating point Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 01/22] softfloat: Fix exception flag handling for float32_to_float16() Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 02/22] softfloat: Add float to 16bit integer conversions Peter Maydell
2013-12-31 14:18 ` Richard Henderson [this message]
2013-12-31 14:22 ` Peter Maydell
2013-12-31 14:29 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 03/22] softfloat: Add 16 bit integer to float conversions Peter Maydell
2013-12-31 14:21 ` Richard Henderson
2013-12-31 14:27 ` Peter Maydell
2013-12-31 14:35 ` Richard Henderson
2013-12-31 14:45 ` Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 04/22] softfloat: Fix float64_to_uint64 Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 05/22] softfloat: Only raise Invalid when conversions to int are out of range Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 06/22] softfloat: Fix factor 2 error for scalbn on denormal inputs Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 07/22] softfloat: Add float32_to_uint64() Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 08/22] softfloat: Fix float64_to_uint64_round_to_zero Peter Maydell
2013-12-31 14:23 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 09/22] softfloat: Fix float64_to_uint32 Peter Maydell
2013-12-31 14:24 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 10/22] softfloat: Fix float64_to_uint32_round_to_zero Peter Maydell
2013-12-31 14:24 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 11/22] softfloat: Provide complete set of accessors for fp state Peter Maydell
2013-12-31 14:26 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 12/22] softfloat: Factor out RoundAndPackFloat16 and NormalizeFloat16Subnormal Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 13/22] softfloat: Add float16 <=> float64 conversion functions Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 14/22] softfloat: Add support for ties-away rounding Peter Maydell
2013-12-31 14:51 ` Richard Henderson
2013-12-31 14:56 ` Peter Maydell
2013-12-31 14:59 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 15/22] target-arm: Prepare VFP_CONV_FIX helpers for A64 uses Peter Maydell
2013-12-31 15:00 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 16/22] target-arm: Rename A32 VFP conversion helpers Peter Maydell
2013-12-31 15:04 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 17/22] target-arm: Ignore most exceptions from scalbn when doing fixpoint conversion Peter Maydell
2013-12-31 15:17 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 18/22] target-arm: A64: Add extra VFP fixed point conversion helpers Peter Maydell
2013-12-31 15:18 ` Richard Henderson
2013-12-31 13:35 ` [Qemu-devel] [PATCH 19/22] target-arm: A64: Add "Floating-point<->fixed-point" instructions Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 20/22] target-arm: A64: Add floating-point<->integer conversion instructions Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 21/22] target-arm: A64: Add 1-source 32-to-32 and 64-to-64 FP instructions Peter Maydell
2013-12-31 13:35 ` [Qemu-devel] [PATCH 22/22] target-arm: A64: Add support for FCVT between half, single and double Peter Maydell
2014-01-02 19:12 ` [Qemu-devel] [PATCH 00/22] A64 decoder patchset 6: rest of floating point Tom Musta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C2D23B.4050309@twiddle.net \
--to=rth@twiddle.net \
--cc=agraf@suse.de \
--cc=alex.bennee@linaro.org \
--cc=aurelien@aurel32.net \
--cc=christoffer.dall@linaro.org \
--cc=claudio.fontana@linaro.org \
--cc=dmueller@suse.de \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=laurent.desnogues@gmail.com \
--cc=matz@suse.de \
--cc=patches@linaro.org \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=tommusta@gmail.com \
--cc=will.newton@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).