From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48248)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy0CR-0001j0-HU
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:21:47 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy0CF-00045c-9i
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:21:39 -0500
Received: from mail-pd0-x231.google.com ([2607:f8b0:400e:c02::231]:40445)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy0CF-00045M-2e
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:21:27 -0500
Received: by mail-pd0-f177.google.com with SMTP id q10so12359886pdj.36
	for <qemu-devel@nongnu.org>; Tue, 31 Dec 2013 06:21:26 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52C2D2E2.7070203@twiddle.net>
Date: Tue, 31 Dec 2013 06:21:22 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1388496958-3542-1-git-send-email-peter.maydell@linaro.org>
	<1388496958-3542-4-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1388496958-3542-4-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/22] softfloat: Add 16 bit integer to
	float conversions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Aurelien Jarno <aurelien@aurel32.net>, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/31/2013 05:35 AM, Peter Maydell wrote:
> +/* We provide the int16 versions for symmetry of API with float-to-int */
> +INLINE float32 int16_to_float32(int_fast16_t v STATUS_PARAM)
> +{
> +    return int32_to_float32(v STATUS_VAR);
> +}

If you're going to have int16 versions, I don't think you should use
int_fast16_t, but rather int16_t so that we will properly truncate the incoming
value.  Otherwise there's not much point in having these, IMO.

And please add blank lines between the functions.


r~