From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48465)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy0ER-0003D2-U2
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:23:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy0EL-0004k8-22
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:23:43 -0500
Received: from mail-pb0-x232.google.com ([2607:f8b0:400e:c01::232]:37407)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Vy0EK-0004ja-RN
	for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:23:36 -0500
Received: by mail-pb0-f50.google.com with SMTP id rr13so12746826pbb.9
	for <qemu-devel@nongnu.org>; Tue, 31 Dec 2013 06:23:36 -0800 (PST)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <52C2D364.4070903@twiddle.net>
Date: Tue, 31 Dec 2013 06:23:32 -0800
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1388496958-3542-1-git-send-email-peter.maydell@linaro.org>
	<1388496958-3542-9-git-send-email-peter.maydell@linaro.org>
In-Reply-To: <1388496958-3542-9-git-send-email-peter.maydell@linaro.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 08/22] softfloat: Fix
	float64_to_uint64_round_to_zero
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: Tom Musta <tommusta@gmail.com>, Peter Crosthwaite <peter.crosthwaite@xilinx.com>, patches@linaro.org, Aurelien Jarno <aurelien@aurel32.net>, Michael Matz <matz@suse.de>, Alexander Graf <agraf@suse.de>, Claudio Fontana <claudio.fontana@linaro.org>, Dirk Mueller <dmueller@suse.de>, Will Newton <will.newton@linaro.org>, Laurent Desnogues <laurent.desnogues@gmail.com>, =?ISO-8859-1?Q?Alex_Benn=E9e?= <alex.bennee@linaro.org>, kvmarm@lists.cs.columbia.edu, Christoffer Dall <christoffer.dall@linaro.org>

On 12/31/2013 05:35 AM, Peter Maydell wrote:
> From: Tom Musta <tommusta@gmail.com>
> 
> The float64_to_uint64_round_to_zero routine is incorrect.
> 
> For example, the following test pattern:
> 
>     46697351FF4AEC29 / 0x1.97351ff4aec29p+103
> 
> currently produces 8000000000000000 instead of FFFFFFFFFFFFFFFF.
> 
> This patch re-implements the routine to temporarily force the
> rounding mode and use the float64_to_uint64 routine.
> 
> This contribution can be licensed under either the softfloat-2a or -2b
> license.
> 
> Signed-off-by: Tom Musta <tommusta@gmail.com>
> Message-id: 1387397961-4894-4-git-send-email-tommusta@gmail.com
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  fpu/softfloat.c | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)

Perhaps a duplicate with Tom's thread, but:

Reviewed-by: Richard Henderson <rth@twiddle.net>


r~