From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vy0HG-0006oD-DL for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:26:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vy0HB-0005Oz-GG for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:26:38 -0500 Received: from mail-pb0-x22c.google.com ([2607:f8b0:400e:c01::22c]:58838) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vy0HB-0005Ot-99 for qemu-devel@nongnu.org; Tue, 31 Dec 2013 09:26:33 -0500 Received: by mail-pb0-f44.google.com with SMTP id rq2so12633906pbb.17 for ; Tue, 31 Dec 2013 06:26:32 -0800 (PST) Sender: Richard Henderson Message-ID: <52C2D414.4060609@twiddle.net> Date: Tue, 31 Dec 2013 06:26:28 -0800 From: Richard Henderson MIME-Version: 1.0 References: <1388496958-3542-1-git-send-email-peter.maydell@linaro.org> <1388496958-3542-12-git-send-email-peter.maydell@linaro.org> In-Reply-To: <1388496958-3542-12-git-send-email-peter.maydell@linaro.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 11/22] softfloat: Provide complete set of accessors for fp state List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell , qemu-devel@nongnu.org Cc: Tom Musta , Peter Crosthwaite , patches@linaro.org, Aurelien Jarno , Michael Matz , Alexander Graf , Claudio Fontana , Dirk Mueller , Will Newton , Laurent Desnogues , =?ISO-8859-1?Q?Alex_Benn=E9e?= , kvmarm@lists.cs.columbia.edu, Christoffer Dall On 12/31/2013 05:35 AM, Peter Maydell wrote: > Tidy up the get/set accessors for the fp state to add missing ones > and make them all inline in softfloat.h rather than some inline and > some not. > > Signed-off-by: Peter Maydell > --- > The specific one we want for A64 is to get the rounding mode, > but we might as well fill in the gaps. > --- > fpu/softfloat.c | 15 --------------- > include/fpu/softfloat.h | 39 ++++++++++++++++++++++++++++++++++++--- > 2 files changed, 36 insertions(+), 18 deletions(-) Reviewed-by: Richard Henderson r~