From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyhCL-0002F2-KH for qemu-devel@nongnu.org; Thu, 02 Jan 2014 07:16:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VyhCC-0001z6-7G for qemu-devel@nongnu.org; Thu, 02 Jan 2014 07:16:25 -0500 Received: from mail-ea0-x236.google.com ([2a00:1450:4013:c01::236]:61778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyhCC-0001z1-0Y for qemu-devel@nongnu.org; Thu, 02 Jan 2014 07:16:16 -0500 Received: by mail-ea0-f182.google.com with SMTP id a15so6234739eae.41 for ; Thu, 02 Jan 2014 04:16:15 -0800 (PST) Sender: Paolo Bonzini Message-ID: <52C5588B.30804@redhat.com> Date: Thu, 02 Jan 2014 13:16:11 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1388640940-12782-1-git-send-email-lig.fnst@cn.fujitsu.com> <52C52170.1040904@redhat.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob loader List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite Cc: Peter Maydell , "qemu-devel@nongnu.org Developers" , Li Guang Il 02/01/2014 11:51, Peter Crosthwaite ha scritto: >> > No, please use "realize" and avoid init. This way you can use an Error* >> > to report the error. >> > >> > Also, the actual load_image_targphys call probably should be done in a >> > reset handler, not at realize time. >> > > Ok I think that settles it. The actual blobbing needs to happen at > reset time. Perhaps the correct approach is to do as much as possible > (file-path / address sanitsation etc) at realize time, then only the > actual blob load happens at reset. Going on what Paolo said, I think > for this device ::init is actually a nop. Yeah, also because init is in fact a legacy interface to realize. Paolo