From: "Andreas Färber" <afaerber@suse.de>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Kewei Yu <keweihk@gmail.com>
Cc: qemu-trivial <qemu-trivial@nongnu.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang
Date: Thu, 02 Jan 2014 15:53:23 +0100 [thread overview]
Message-ID: <52C57D63.4080809@suse.de> (raw)
In-Reply-To: <CAEgOgz5_cT3B38fEUChB7+w7KTsZL5bbTQYiAvp6_i47nNvFMw@mail.gmail.com>
Am 01.01.2014 05:40, schrieb Peter Crosthwaite:
> On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu <keweihk@gmail.com> wrote:
>> 2013/12/31 Peter Crosthwaite <peter.crosthwaite@xilinx.com>
>>> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu <keweihk@gmail.com> wrote:
>>>> When we disabling vnc from "./configure", the qemu can't use the vnc
>>>> option.
[...]
>>>> So qtest can't use the "vnc -none ", otherwise "make check" will hang.
>>>
>>> Curious, why exactly does make check hang? Shouldn't it just fail with
>>> an error result in this case?
>>
>> Yeah, there is an error result "VNC support is disabled".
>
> I think its just terminology then. s/hangs/fails.
Actually no. When qtest gets an unsupported command line argument, so
that QEMU exits right away, then qtest hangs, waiting for the process.
This was easily reproducible by mistyping machine names in my qom-test.
That's a separate issue though.
Regards,
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-01-02 14:53 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 4:42 [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang Kewei Yu
2013-12-31 12:33 ` Peter Crosthwaite
2013-12-31 13:29 ` Kewei Yu
2014-01-01 1:47 ` Kewei Yu
2014-01-01 2:06 ` Peter Maydell
2014-01-01 2:29 ` Kewei Yu
2014-01-01 4:39 ` Peter Crosthwaite
2014-01-01 4:40 ` Peter Crosthwaite
2014-01-02 14:53 ` Andreas Färber [this message]
2014-01-03 3:01 ` Kewei Yu
2014-01-03 3:04 ` Peter Crosthwaite
2014-01-02 8:15 ` Paolo Bonzini
2014-01-02 9:58 ` Kewei Yu
2014-01-02 14:45 ` Andreas Färber
2014-01-03 9:26 ` Paolo Bonzini
2014-01-06 4:29 ` Kewei Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52C57D63.4080809@suse.de \
--to=afaerber@suse.de \
--cc=keweihk@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).