From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyjeQ-0006ya-3K for qemu-devel@nongnu.org; Thu, 02 Jan 2014 09:53:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VyjeJ-0004Hr-Ty for qemu-devel@nongnu.org; Thu, 02 Jan 2014 09:53:34 -0500 Message-ID: <52C57D63.4080809@suse.de> Date: Thu, 02 Jan 2014 15:53:23 +0100 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1388464944-26911-1-git-send-email-keweihk@gmail.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 1/1] qtest: Fix the bug about disabling vnc causes "make check" hang List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Crosthwaite , Kewei Yu Cc: qemu-trivial , "qemu-devel@nongnu.org Developers" , Stefan Hajnoczi Am 01.01.2014 05:40, schrieb Peter Crosthwaite: > On Tue, Dec 31, 2013 at 11:29 PM, Kewei Yu wrote: >> 2013/12/31 Peter Crosthwaite >>> On Tue, Dec 31, 2013 at 2:42 PM, Kewei Yu wrote: >>>> When we disabling vnc from "./configure", the qemu can't use the vnc >>>> option. [...] >>>> So qtest can't use the "vnc -none ", otherwise "make check" will han= g. >>> >>> Curious, why exactly does make check hang? Shouldn't it just fail wit= h >>> an error result in this case? >> >> Yeah, there is an error result "VNC support is disabled". >=20 > I think its just terminology then. s/hangs/fails. Actually no. When qtest gets an unsupported command line argument, so that QEMU exits right away, then qtest hangs, waiting for the process. This was easily reproducible by mistyping machine names in my qom-test. That's a separate issue though. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg