From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:33222)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vyq4w-0001s2-Ed
	for qemu-devel@nongnu.org; Thu, 02 Jan 2014 16:45:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Vyq4n-0002o5-Vv
	for qemu-devel@nongnu.org; Thu, 02 Jan 2014 16:45:22 -0500
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <52C5DDD6.2060301@redhat.com>
Date: Thu, 02 Jan 2014 22:44:54 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1382099622-87967-1-git-send-email-nwhitehorn@freebsd.org>
	<C7A0CCFD-3BC3-4182-9F97-A94ADDBE57EE@suse.de>
	<46A0A8D3-7588-4C43-9137-67AE089FAEAB@suse.de>
	<CAN05THQW=RorO5iNyxbfVYNxWvhk=G+FP4+KK7NPYqCBtp6=_A@mail.gmail.com>
	<52C5AC9E.5060906@freebsd.org>
In-Reply-To: <52C5AC9E.5060906@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr_vscsi: Fix REPORT_LUNS
	handling
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Nathan Whitehorn <nwhitehorn@freebsd.org>
Cc: qemu-ppc <qemu-ppc@nongnu.org>, Alexander Graf <agraf@suse.de>, ronnie sahlberg <ronniesahlberg@gmail.com>, QEMU Developers <qemu-devel@nongnu.org>

Il 02/01/2014 19:14, Nathan Whitehorn ha scritto:
>> > He should do something like :
>> >     resp_data[i] |= dev->id & 0x3f;
>> > here to avoid a dev->id > 63 from spilling into the address method field.
>> >
>> > Or probably should have a check for
>> > if dev->id > 3  then fail
> OK.

No need for that:

    .max_channel = 7, /* logical unit addressing format */
    .max_target = 63,
    .max_lun = 31,

dev->id is thus bounded to 0..63.

Paolo