From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38035)
	by lists.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Vz2uD-00017l-38
	for qemu-devel@nongnu.org; Fri, 03 Jan 2014 06:27:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pl@kamp.de>) id 1Vz2u7-0008KO-Tv
	for qemu-devel@nongnu.org; Fri, 03 Jan 2014 06:27:09 -0500
Received: from mx.ipv6.kamp.de ([2a02:248:0:51::16]:54117 helo=mx01.kamp.de)
	by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from <pl@kamp.de>)
	id 1Vz2u7-0008JR-Jl
	for qemu-devel@nongnu.org; Fri, 03 Jan 2014 06:27:03 -0500
Message-ID: <52C69EDF.7020500@kamp.de>
Date: Fri, 03 Jan 2014 12:28:31 +0100
From: Peter Lieven <pl@kamp.de>
MIME-Version: 1.0
References: <1388062130-21126-1-git-send-email-pl@kamp.de>
	<CAJSP0QUyhMohV7n22jytTgxtO8hyLgGnRKoxyBrVjuYWaikffA@mail.gmail.com>
In-Reply-To: <CAJSP0QUyhMohV7n22jytTgxtO8hyLgGnRKoxyBrVjuYWaikffA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv5] block: add native support for NFS
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, ronnie sahlberg <ronniesahlberg@gmail.com>, qemu-devel <qemu-devel@nongnu.org>, Orit Wasserman <owasserm@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>

On 03.01.2014 11:37, Stefan Hajnoczi wrote:
> Looks good.  In order to merge this new block driver qemu-iotests
> support for nfs is required.  That way the block driver can be exercised
> and checked for regressions (I guess you performed manual testing
> during development).
>
> Please see tests/qemu-iotests/common for examples of
> NBD/SSH/Sheepdog/etc support.
>
> The qemu-iotests test suite with raw, qcow2, and vmdk formats should
> work on top of NFS.  Assuming you have an NFS server already running
> on localhost, something like the following should succeed:
>
>    cd tests/qemu-iotests
>    ln -s ../../x86_64-softmmu/qemu-system-x86_64 qemu
>    ln -s ../../qemu-img .
>    ln -s ../../qemu-io .
>    ./check -nfs # raw format by default
>    ./check -nfs -qcow2
>    ./check -nfs -vmdk
>
> Maybe -nfs should take the base NFS URI as an argument to allow more
> flexible test configurations.  It's up to you.
>
> More info on qemu-iotests: http://qemu-project.org/Documentation/QemuIoTests
it seems that several tests are broken since they use commands like
rm -f or mv and have protocol generic. shall I fix this?

Peter