From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38602)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1W01ks-0002ko-Ez
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 23:25:39 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1W01km-0004Ai-DP
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 23:25:34 -0500
Received: from [222.73.24.84] (port=28476 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lig.fnst@cn.fujitsu.com>) id 1W01km-0004AF-1U
	for qemu-devel@nongnu.org; Sun, 05 Jan 2014 23:25:28 -0500
Message-ID: <52CA2FA1.6080002@cn.fujitsu.com>
Date: Mon, 06 Jan 2014 12:22:57 +0800
From: Li Guang <lig.fnst@cn.fujitsu.com>
MIME-Version: 1.0
References: <1388640940-12782-1-git-send-email-lig.fnst@cn.fujitsu.com>	<CAEgOgz6_RFp6PPB8KZSLkVBe8XKAB3J1FDeR9rngCFQqOns=aw@mail.gmail.com>	<52C52170.1040904@redhat.com>	<CAEgOgz6jNzc8A1k6S6LXEj5V=tkmsSRjjrqKXELDxkLvog5Z8Q@mail.gmail.com>	<52C5588B.30804@redhat.com>
	<52C9FE6B.4050408@cn.fujitsu.com>	<52CA2922.1010308@cn.fujitsu.com>
	<CAEgOgz6Kx=HWJ1zTn7=ORXG+UW8TN17P=KZ8mnJAesLk6vyDJA@mail.gmail.com>
In-Reply-To: <CAEgOgz6Kx=HWJ1zTn7=ORXG+UW8TN17P=KZ8mnJAesLk6vyDJA@mail.gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Subject: Re: [Qemu-devel] [PATCH] hw/misc/blob-loader: add a generic blob
 loader
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, "qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>

Peter Crosthwaite wrote:
> On Mon, Jan 6, 2014 at 1:55 PM, Li Guang<lig.fnst@cn.fujitsu.com>  wrote:
>    
>> Li Guang wrote:
>>      
>>> Paolo Bonzini wrote:
>>>        
>>>> Il 02/01/2014 11:51, Peter Crosthwaite ha scritto:
>>>>          
>>>>>>> No, please use "realize" and avoid init.  This way you can use an
>>>>>>> Error*
>>>>>>> to report the error.
>>>>>>>
>>>>>>> Also, the actual load_image_targphys call probably should be done in a
>>>>>>> reset handler, not at realize time.
>>>>>>>
>>>>>>>                
>>>>> Ok I think that settles it. The actual blobbing needs to happen at
>>>>> reset time. Perhaps the correct approach is to do as much as possible
>>>>> (file-path / address sanitsation etc) at realize time, then only the
>>>>> actual blob load happens at reset. Going on what Paolo said, I think
>>>>> for this device ::init is actually a nop.
>>>>>            
>>>> Yeah, also because init is in fact a legacy interface to realize.
>>>>
>>>> Paolo
>>>>
>>>>          
>>> Ok, thanks!
>>>
>>>
>>>        
>> Sorry, seems load blob at reset handler can't do the right job,
>> while the same action can play very well at init or realize.
>>      
> What's the exact problem with the reset idea?
>
>
>    
code snippet:
static void blob_loader_reset(DeviceState *dev)
{
     BlobLoaderState *s = BLOB_LOADER(dev);

     if (load_image_targphys(s->file, s->hwaddr, MAX_BLOB_SIZE) < 0) {
         error_report("can't load %s\n", s->file);
         exit(1);
     }
}

if it is device reset handler, no result,
kernel doesn't find and parse blob,
if it is called at device realize phase,
it works.

Thanks!

>> any suggestion to figure out this problem?
>>
>> Thanks!
>>
>>
>>
>>      
>
>