From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48574)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W030r-0007r4-Pm
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 00:46:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W030m-0005P7-Ty
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 00:46:09 -0500
Received: from mx1.redhat.com ([209.132.183.28]:15453)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W030m-0005P3-Kc
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 00:46:04 -0500
Message-ID: <52CA42FC.7090402@redhat.com>
Date: Mon, 06 Jan 2014 13:45:32 +0800
From: Fam Zheng <famz@redhat.com>
MIME-Version: 1.0
References: <1388942528-10453-1-git-send-email-pl@kamp.de>
	<1388942528-10453-7-git-send-email-pl@kamp.de>
In-Reply-To: <1388942528-10453-7-git-send-email-pl@kamp.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCHv2 06/18] qemu-iotests: fix test 018 to work
	with any protocol
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, ronniesahlberg@gmail.com, Jeff Cody <jcody@redhat.com>, Max Reitz <mreitz@redhat.com>, owasserm@redhat.com, Federico Simoncelli <fsimonce@redhat.com>, Stefan Hajnoczi <stefanha@redhat.com>, Wenchao Xia <xiawenc@linux.vnet.ibm.com>

On 2014=E5=B9=B401=E6=9C=8806=E6=97=A5 01:21, Peter Lieven wrote:
> Signed-off-by: Peter Lieven <pl@kamp.de>
> ---
>   tests/qemu-iotests/018     |   22 +++++++++-------------
>   tests/qemu-iotests/018.out |    4 ++--
>   2 files changed, 11 insertions(+), 15 deletions(-)
>
> diff --git a/tests/qemu-iotests/018 b/tests/qemu-iotests/018
> index aa9d3cb..fecf281 100755
> --- a/tests/qemu-iotests/018
> +++ b/tests/qemu-iotests/018
> @@ -41,46 +41,42 @@ trap "_cleanup; exit \$status" 0 1 2 3 15
>
>   # Any format supporting backing files
>   _supported_fmt qcow qcow2 vmdk qed
> -_supported_proto file
> +_supported_proto generic
>   _supported_os Linux
>
>   TEST_OFFSETS=3D"0 4294967296"
>
> -TEST_IMG_SAVE=3D$TEST_IMG
> -TEST_IMG=3D$TEST_IMG.base
> -_make_test_img 6G
> +TEST_IMG=3D$TEST_IMG.base _make_test_img 6G
>
>   echo "Filling base image"
>   echo
>
>   for offset in $TEST_OFFSETS; do
>       # Some clusters with alternating backing file/image file reads
> -    io writev $(( offset )) 512 1024 64
> +    TEST_IMG=3D$TEST_IMG.base io writev $(( offset )) 512 1024 64
>
>       # Complete backing clusters
> -    io writev $(( offset  + 64 * 1024))  65536 65536 1
> +    TEST_IMG=3D$TEST_IMG.base io writev $(( offset  + 64 * 1024))  655=
36 65536 1
>   done
> -_check_test_img
> +TEST_IMG=3D$TEST_IMG.base _check_test_img
>
>   echo "Creating test image with backing file"
>   echo
>
> -TEST_IMG=3D$TEST_IMG_SAVE
> -_make_test_img -b "$TEST_IMG.base" 6G
> +TEST_IMG=3D$TEST_IMG.orig _make_test_img -b "$TEST_IMG.base" 6G
>
>   echo "Filling test image"
>   echo
>
>   for offset in $TEST_OFFSETS; do
>       # Some clusters with alternating backing file/image file reads
> -    io writev $(( offset + 512 )) 512 1024 64
> +    TEST_IMG=3D$TEST_IMG.orig io writev $(( offset + 512 )) 512 1024 6=
4
>
>       # Complete test image clusters
> -    io writev $(( offset + 64 * 1024 + 65536))  65536 65536 1
> +    TEST_IMG=3D$TEST_IMG.orig io writev $(( offset + 64 * 1024 + 65536=
))  65536 65536 1
>   done
> -_check_test_img
> +TEST_IMG=3D$TEST_IMG.orig _check_test_img
>
> -mv "$TEST_IMG" "$TEST_IMG.orig"

The same pattern. But I'm stopping to duplicate the same comment.

Fam