From: Fam Zheng <famz@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>, Peter Lieven <pl@kamp.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] qemu-iotests: test 051 fails
Date: Mon, 06 Jan 2014 14:15:30 +0800 [thread overview]
Message-ID: <52CA4A02.8030808@redhat.com> (raw)
In-Reply-To: <20140106061438.GB20766@stefanha-thinkpad.redhat.com>
On 2014年01月06日 14:14, Stefan Hajnoczi wrote:
> On Mon, Jan 06, 2014 at 09:44:30AM +0800, Fam Zheng wrote:
>> On 2014年01月05日 02:39, Peter Lieven wrote:
>>> ~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51
>>> QEMU -- ./qemu
>>> QEMU_IMG -- ./qemu-img
>>> QEMU_IO -- ./qemu-io
>>> QEMU_NBD -- /usr/local/bin/qemu-nbd
>>> IMGFMT -- qcow2 (compat=1.1)
>>> IMGPROTO -- file
>>> PLATFORM -- Linux/x86_64 lieven-pc 3.2.0-57-generic
>>> SOCKET_SCM_HELPER --
>>>
>>> 051 - output mismatch (see 051.out.bad)
>>> --- 051.out 2014-01-04 19:11:31.557812472 +0100
>>> +++ 051.out.bad 2014-01-04 19:38:03.185810819 +0100
>>> @@ -91,7 +91,6 @@
>>> QEMU X.Y.Z monitor - type 'help' for more information
>>> (qemu) QEMU_PROG: -drive if=virtio: Device needs media, but drive is empty
>>> QEMU_PROG: -drive if=virtio: Device initialization failed.
>>> -QEMU_PROG: -drive if=virtio: Device initialization failed.
>>> QEMU_PROG: -drive if=virtio: Device 'virtio-blk-pci' could not be initialized
>>>
>>> Testing: -drive if=scsi
>>> Failures: 051
>>> Failed 1 of 1 tests
>>>
>>> Peter
>>>
>>
>> Yes, this is the bad commit:
>>
>> commit 75884afd5c6c42e523b08565e289dbe319e17ad9
>> Author: Andreas Färber <afaerber@suse.de>
>> Date: Tue Jul 30 01:35:08 2013 +0200
>>
>> virtio-blk: Convert to QOM realize
>>
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> I guess simply removing the duplicated line in the output file is
>> enough. I'll post a patch for it, thanks for the report!
>
> See my earlier email to this thread. I already posted a patch.
>
That's good, thanks!
Fam
next prev parent reply other threads:[~2014-01-06 6:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-04 18:39 [Qemu-devel] qemu-iotests: test 051 fails Peter Lieven
2014-01-06 1:44 ` Fam Zheng
2014-01-06 6:14 ` Stefan Hajnoczi
2014-01-06 6:15 ` Fam Zheng [this message]
2014-01-06 4:25 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CA4A02.8030808@redhat.com \
--to=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).