From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51655)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W03Te-0008GF-TU
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 01:15:59 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W03TZ-0003RC-WB
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 01:15:54 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23428)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <famz@redhat.com>) id 1W03TZ-0003R3-Dw
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 01:15:49 -0500
Message-ID: <52CA4A02.8030808@redhat.com>
Date: Mon, 06 Jan 2014 14:15:30 +0800
From: Fam Zheng <famz@redhat.com>
MIME-Version: 1.0
References: <52C8554C.9010900@kamp.de> <52CA0A7E.2050407@redhat.com>
	<20140106061438.GB20766@stefanha-thinkpad.redhat.com>
In-Reply-To: <20140106061438.GB20766@stefanha-thinkpad.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] qemu-iotests: test 051 fails
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, Peter Lieven <pl@kamp.de>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 2014=E5=B9=B401=E6=9C=8806=E6=97=A5 14:14, Stefan Hajnoczi wrote:
> On Mon, Jan 06, 2014 at 09:44:30AM +0800, Fam Zheng wrote:
>> On 2014=E5=B9=B401=E6=9C=8805=E6=97=A5 02:39, Peter Lieven wrote:
>>> ~/git/qemu/tests/qemu-iotests$ ./check -qcow2 51
>>> QEMU          -- ./qemu
>>> QEMU_IMG      -- ./qemu-img
>>> QEMU_IO       -- ./qemu-io
>>> QEMU_NBD      -- /usr/local/bin/qemu-nbd
>>> IMGFMT        -- qcow2 (compat=3D1.1)
>>> IMGPROTO      -- file
>>> PLATFORM      -- Linux/x86_64 lieven-pc 3.2.0-57-generic
>>> SOCKET_SCM_HELPER --
>>>
>>> 051         - output mismatch (see 051.out.bad)
>>> --- 051.out    2014-01-04 19:11:31.557812472 +0100
>>> +++ 051.out.bad    2014-01-04 19:38:03.185810819 +0100
>>> @@ -91,7 +91,6 @@
>>>   QEMU X.Y.Z monitor - type 'help' for more information
>>>   (qemu) QEMU_PROG: -drive if=3Dvirtio: Device needs media, but drive=
 is empty
>>>   QEMU_PROG: -drive if=3Dvirtio: Device initialization failed.
>>> -QEMU_PROG: -drive if=3Dvirtio: Device initialization failed.
>>>   QEMU_PROG: -drive if=3Dvirtio: Device 'virtio-blk-pci' could not be=
 initialized
>>>
>>>   Testing: -drive if=3Dscsi
>>> Failures: 051
>>> Failed 1 of 1 tests
>>>
>>> Peter
>>>
>>
>> Yes, this is the bad commit:
>>
>> commit 75884afd5c6c42e523b08565e289dbe319e17ad9
>> Author: Andreas F=C3=A4rber <afaerber@suse.de>
>> Date:   Tue Jul 30 01:35:08 2013 +0200
>>
>>      virtio-blk: Convert to QOM realize
>>
>>      Signed-off-by: Andreas F=C3=A4rber <afaerber@suse.de>
>>      Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>>
>> I guess simply removing the duplicated line in the output file is
>> enough. I'll post a patch for it, thanks for the report!
>
> See my earlier email to this thread.  I already posted a patch.
>

That's good, thanks!

Fam