From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: sw@weilnetz.de, aliguori@amazon.com
Subject: Re: [Qemu-devel] [PATCHv3 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro
Date: Mon, 06 Jan 2014 14:52:38 +0800 [thread overview]
Message-ID: <52CA52B6.5070202@linux.vnet.ibm.com> (raw)
In-Reply-To: <1388944951-14767-2-git-send-email-pl@kamp.de>
> @@ -781,10 +784,10 @@ static void vnc_dpy_copy(DisplayChangeListener *dcl,
> if ((s = w - w_lim) == 0)
> break;
> } else if (!x) {
> - s = (16 - (dst_x % 16));
> + s = (16 - (dst_x % VNC_DIRTY_PIXELS_PER_BIT));
Should it be
s = (VNC_DIRTY_PIXELS_PER_BIT - (dst_x % VNC_DIRTY_PIXELS_PER_BIT));
?
next prev parent reply other threads:[~2014-01-06 6:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-05 18:02 [Qemu-devel] [PATCHv3 0/6] ui/vnc: update optimizations Peter Lieven
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 1/6] ui/vnc: introduce VNC_DIRTY_PIXELS_PER_BIT macro Peter Lieven
2014-01-06 6:52 ` Wenchao Xia [this message]
2014-01-06 8:02 ` Peter Lieven
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 2/6] ui/vnc: derive cmp_bytes from VNC_DIRTY_PIXELS_PER_BIT Peter Lieven
2014-01-06 7:03 ` Wenchao Xia
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 3/6] ui/vnc: optimize dirty bitmap tracking Peter Lieven
2014-01-06 10:08 ` Wenchao Xia
2014-01-06 13:31 ` Peter Lieven
2014-01-07 2:00 ` Wenchao Xia
2014-01-06 17:37 ` Peter Lieven
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 4/6] ui/vnc: optimize clearing in find_and_clear_dirty_height() Peter Lieven
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 5/6] ui/vnc: optimize setting in vnc_dpy_update() Peter Lieven
2014-01-05 18:02 ` [Qemu-devel] [PATCHv3 6/6] ui/vnc: disable adaptive update calculations if not needed Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CA52B6.5070202@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=aliguori@amazon.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).