From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:55752)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1W043j-0002gA-Qz
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 01:53:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1W043a-0003A5-TI
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 01:53:11 -0500
Received: from e28smtp09.in.ibm.com ([122.248.162.9]:55781)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <xiawenc@linux.vnet.ibm.com>) id 1W043X-000383-TP
	for qemu-devel@nongnu.org; Mon, 06 Jan 2014 01:53:02 -0500
Received: from /spool/local
	by e28smtp09.in.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <xiawenc@linux.vnet.ibm.com>;
	Mon, 6 Jan 2014 12:22:45 +0530
Received: from d28relay01.in.ibm.com (d28relay01.in.ibm.com [9.184.220.58])
	by d28dlp03.in.ibm.com (Postfix) with ESMTP id 20BD01258053
	for <qemu-devel@nongnu.org>; Mon,  6 Jan 2014 12:24:11 +0530 (IST)
Received: from d28av05.in.ibm.com (d28av05.in.ibm.com [9.184.220.67])
	by d28relay01.in.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	s066qZpd50331700
	for <qemu-devel@nongnu.org>; Mon, 6 Jan 2014 12:22:36 +0530
Received: from d28av05.in.ibm.com (localhost [127.0.0.1])
	by d28av05.in.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id
	s066qeMW025765
	for <qemu-devel@nongnu.org>; Mon, 6 Jan 2014 12:22:40 +0530
Message-ID: <52CA52B6.5070202@linux.vnet.ibm.com>
Date: Mon, 06 Jan 2014 14:52:38 +0800
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1388944951-14767-1-git-send-email-pl@kamp.de>
	<1388944951-14767-2-git-send-email-pl@kamp.de>
In-Reply-To: <1388944951-14767-2-git-send-email-pl@kamp.de>
Content-Type: text/plain; charset=GB2312
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCHv3 1/6] ui/vnc:
 introduce	VNC_DIRTY_PIXELS_PER_BIT macro
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Lieven <pl@kamp.de>, qemu-devel@nongnu.org
Cc: sw@weilnetz.de, aliguori@amazon.com

> @@ -781,10 +784,10 @@ static void vnc_dpy_copy(DisplayChangeListener *dcl,
>                   if ((s = w - w_lim) == 0)
>                       break;
>               } else if (!x) {
> -                s = (16 - (dst_x % 16));
> +                s = (16 - (dst_x % VNC_DIRTY_PIXELS_PER_BIT));

Should it be
s = (VNC_DIRTY_PIXELS_PER_BIT - (dst_x % VNC_DIRTY_PIXELS_PER_BIT));
?