From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39579) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0DaR-0004NA-TO for qemu-devel@nongnu.org; Mon, 06 Jan 2014 12:03:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W0DaL-0003pd-PP for qemu-devel@nongnu.org; Mon, 06 Jan 2014 12:03:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W0DaL-0003oU-HJ for qemu-devel@nongnu.org; Mon, 06 Jan 2014 12:03:29 -0500 Message-ID: <52CAE1D5.9000500@redhat.com> Date: Mon, 06 Jan 2014 18:03:17 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1388906864-1083-1-git-send-email-qiaonuohan@cn.fujitsu.com> <1388906864-1083-2-git-send-email-qiaonuohan@cn.fujitsu.com> In-Reply-To: <1388906864-1083-2-git-send-email-qiaonuohan@cn.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v6 01/11] dump: Add argument to write_elfxx_notes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qiao Nuohan Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com, kumagai-atsushi@mxc.nes.nec.co.jp, anderson@redhat.com, akong@redhat.com, afaerber@suse.de On 01/05/14 08:27, Qiao Nuohan wrote: > write_elf32_notes/wirte_elf64_notes use fd_write_vmcore to write elf notes to > vmcore. Adding parameter "WriteCoreDumpFunction f" makes it available to choose > the method of writing elf notes > > Signed-off-by: Qiao Nuohan > --- > dump.c | 16 ++++++++-------- > 1 files changed, 8 insertions(+), 8 deletions(-) I assume the direct calls to fd_write_vmcore() (which we're not replacing here) will be substituted / abstracted later on in the series. Reviewed-by: Laszlo Ersek